From: Jason Gunthorpe <jgg@ziepe.ca>
To: oshri.alkoby@nuvoton.com
Cc: Dan.Morav@nuvoton.com, nayna@linux.vnet.ibm.com,
dana.cohen@nuvoton.com, linux-integrity@vger.kernel.org,
gcwilson@us.ibm.com
Subject: Re: device tree "compatible" string value for Nuvoton TPM 75xxx
Date: Mon, 21 Jan 2019 09:58:48 -0700 [thread overview]
Message-ID: <20190121165848.GC25163@ziepe.ca> (raw)
In-Reply-To: <60e23fd0f0ff4d1f8954034237ae8865@NTILML02.nuvoton.com>
On Mon, Jan 21, 2019 at 04:55:23PM +0000, oshri.alkoby@nuvoton.com wrote:
> Hi Jason,
>
> Since the driver implements the I2C interface defined by the TCG
> PTP, wouldn't it be better to set the string to be something like
> 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)? Any TPM that
> implements this protocol can use this driver.
Yes, probably, we've done that for LPC ..
But the device compatabile string should still be something like:
'nuvoton,npct751','tcg,tpm-i2c-ptp'
In that case
Jason
next prev parent reply other threads:[~2019-01-21 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 15:34 device tree "compatible" string value for Nuvoton TPM 75xxx Nayna
2019-01-20 15:53 ` Dan.Morav
2019-01-21 2:26 ` Jason Gunthorpe
2019-01-21 13:51 ` Dan.Morav
2019-01-21 16:55 ` oshri.alkoby
2019-01-21 16:58 ` Jason Gunthorpe [this message]
2019-01-21 19:16 ` Peter Huewe
2019-01-21 19:51 ` Jason Gunthorpe
2019-01-23 20:22 ` Nayna
2019-01-31 21:46 ` Nayna
2019-02-04 16:39 ` oshri.alkoby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121165848.GC25163@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Dan.Morav@nuvoton.com \
--cc=dana.cohen@nuvoton.com \
--cc=gcwilson@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=oshri.alkoby@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).