From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
linux-integrity@vger.kernel.org, tglx@linutronix.de,
Jason Gunthorpe <jgg@ziepe.ca>,
Philip Tricca <philip.b.tricca@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>
Subject: Re: [PATCH] tpm: remove tpm_dev_wq_lock
Date: Mon, 4 Nov 2019 10:37:09 -0700 [thread overview]
Message-ID: <20191104173709.qqmdiacytyimbqhx@cantor> (raw)
In-Reply-To: <20191104143957.onsfuvmwfuvmfuu6@linutronix.de>
On Mon Nov 04 19, Sebastian Andrzej Siewior wrote:
>sorry for that late reply, was traveling…
>
>On 2019-10-28 22:26:37 [+0200], Jarkko Sakkinen wrote:
>> > OK, so. Gave a relook at this:
>> >
>> > This gives checkpatch.pl error:
>> >
>> > 0012-tpm-remove-tpm_dev_wq_lock.patch
>> > -------------------------------------
>> > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9e1b74a63f77 ("tpm: add support for nonblocking operation")'
>> > #8:
>> > 9e1b74a63f776 ("tpm: add support for nonblocking operation")
>> >
>> > total: 1 errors, 0 warnings, 7 lines checked
>> >
>> > NOTE: For some of the reported defects, checkpatch may be able to
>> > mechanically convert to the typical style using --fix or --fix-inplace.
>> >
>> > Please send me a new patch with a legit fixes line. It is a fix to
>> > regression even if it is a cosmetic one.
>> >
>> > I'll drop the current patch from my tree and apply a new one once
>> > I get it from you.
>
>Can you please explain what is wrong with that one? It is exactly as
>suggested by the error line.
>
>> > Thanks.
>> >
>> > /Jarkko
>>
>> AFAIK cc stable triggers stable backport, not fixes line alone (not
>> 100% sure about this though). Anyway even my original response was
>> meant to this patch I recall now that I bumped into that checkpatch
>> error.
>
>The cc: for stable and fixes are high indicators for it to be
>considered. These days even a few keywords in the commit message might
>let Sasha's script decide to pick/suggest a patch for stable.
>
>> /Jarkko
>
>Sebastian
It looks like checkpatch is expecting the word commit to precede the hash on the same line.
I get no errors with the following:
Added in
commit 9e1b74a63f776 ("tpm: add support for nonblocking operation")
but never actually used it.
Fixes: 9e1b74a63f776 ("tpm: add support for nonblocking operation")
Cc: Philip Tricca <philip.b.tricca@intel.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
next prev parent reply other threads:[~2019-11-04 17:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 10:58 [PATCH] tpm: remove tpm_dev_wq_lock Sebastian Andrzej Siewior
2019-02-11 14:11 ` Jarkko Sakkinen
2019-10-10 16:03 ` Sebastian Andrzej Siewior
2019-10-14 19:39 ` Jarkko Sakkinen
2019-10-28 20:24 ` Jarkko Sakkinen
2019-10-28 20:26 ` Jarkko Sakkinen
2019-11-04 14:39 ` Sebastian Andrzej Siewior
2019-11-04 17:37 ` Jerry Snitselaar [this message]
2019-11-04 17:44 ` Sebastian Andrzej Siewior
2019-11-04 18:27 ` Jerry Snitselaar
2019-11-07 16:10 ` Sebastian Andrzej Siewior
2019-11-07 18:35 ` Jarkko Sakkinen
2019-11-14 11:16 ` Sebastian Andrzej Siewior
2019-11-15 17:34 ` Jarkko Sakkinen
2019-02-12 1:45 ` Tadeusz Struk
2020-12-14 22:07 ` [PATCH V2] tpm: Remove tpm_dev_wq_lock Thomas Gleixner
2021-01-04 18:21 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104173709.qqmdiacytyimbqhx@cantor \
--to=jsnitsel@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=philip.b.tricca@intel.com \
--cc=tadeusz.struk@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).