From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH v5 0/6] TPM 2.0 trusted keys with attached policy
Date: Thu, 20 Feb 2020 22:17:03 +0200 [thread overview]
Message-ID: <20200220201703.GA24990@linux.intel.com> (raw)
In-Reply-To: <20200130101812.6271-1-James.Bottomley@HansenPartnership.com>
On Thu, Jan 30, 2020 at 11:18:06AM +0100, James Bottomley wrote:
> This is mainly a respin to add more spacing as Jarkko requested.
> However, I also added the seal/unseal operations to the
> openssl_tpm2_engine (next branch):
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jejb/openssl_tpm2_engine.git/
>
> With the result that the kernel code completely failed the
> interoperability checks because the ASN.1 format requires the TPM2B
> length prepended to the public and private blobs. I corrected this in
> patch 4 and now all the interoperability tests are passing.
>
> General cover letter:
>
> This patch updates the trusted key code to export keys in the ASN.1
> format used by current TPM key tools (openssl_tpm2_engine and
> openconnect). It also simplifies the use of policy with keys because
> the ASN.1 format is designed to carry a description of how to
> construct the policy, with the result that simple policies (like
> authorization and PCR locking) can now be constructed and used in the
> kernel, bringing the TPM 2.0 policy use into line with how TPM 1.2
> works.
>
> James
>
> ---
>
> James Bottomley (6):
> lib: add ASN.1 encoder
> oid_registry: Add TCG defined OIDS for TPM keys
> security: keys: trusted fix tpm2 authorizations
> security: keys: trusted: use ASN.1 TPM2 key format for the blobs
> security: keys: trusted: add ability to specify arbitrary policy
> security: keys: trusted: implement counter/timer policy
>
> Documentation/security/keys/trusted-encrypted.rst | 64 ++-
> include/keys/trusted-type.h | 7 +-
> include/linux/asn1_encoder.h | 32 ++
> include/linux/oid_registry.h | 5 +
> include/linux/tpm.h | 8 +
> lib/Makefile | 2 +-
> lib/asn1_encoder.c | 431 ++++++++++++++++++++
> security/keys/Kconfig | 2 +
> security/keys/trusted-keys/Makefile | 2 +-
> security/keys/trusted-keys/tpm2-policy.c | 463 ++++++++++++++++++++++
> security/keys/trusted-keys/tpm2-policy.h | 31 ++
> security/keys/trusted-keys/tpm2key.asn1 | 23 ++
> security/keys/trusted-keys/trusted_tpm1.c | 50 ++-
> security/keys/trusted-keys/trusted_tpm2.c | 370 +++++++++++++++--
> 14 files changed, 1454 insertions(+), 36 deletions(-)
> create mode 100644 include/linux/asn1_encoder.h
> create mode 100644 lib/asn1_encoder.c
> create mode 100644 security/keys/trusted-keys/tpm2-policy.c
> create mode 100644 security/keys/trusted-keys/tpm2-policy.h
> create mode 100644 security/keys/trusted-keys/tpm2key.asn1
>
> --
> 2.16.4
Somehow managed to drown this to my emails. Looking into next week.
/Jarkko
>
prev parent reply other threads:[~2020-02-20 20:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 10:18 [PATCH v5 0/6] TPM 2.0 trusted keys with attached policy James Bottomley
2020-01-30 10:18 ` [PATCH v5 1/6] lib: add ASN.1 encoder James Bottomley
2020-01-30 10:18 ` [PATCH v5 2/6] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2020-01-30 10:18 ` [PATCH v5 3/6] security: keys: trusted fix tpm2 authorizations James Bottomley
2020-02-25 16:48 ` Jarkko Sakkinen
2020-02-26 15:15 ` Jarkko Sakkinen
2020-02-27 0:58 ` James Bottomley
2020-02-27 16:19 ` Jarkko Sakkinen
2020-02-27 16:21 ` James Bottomley
2020-02-27 17:49 ` James Bottomley
2020-03-02 11:08 ` Jarkko Sakkinen
2020-01-30 10:18 ` [PATCH v5 4/6] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2020-02-03 16:54 ` James Prestwood
2020-02-27 0:02 ` James Bottomley
2020-02-27 0:20 ` James Prestwood
2020-02-27 0:54 ` James Bottomley
2020-02-27 17:19 ` James Prestwood
2020-02-27 20:19 ` James Bottomley
2020-02-27 20:26 ` James Bottomley
2020-02-27 20:44 ` James Prestwood
2020-02-27 20:57 ` James Prestwood
2020-07-12 21:38 ` Ken Goldman
2020-07-12 21:54 ` James Bottomley
2020-03-02 19:00 ` James Prestwood
2020-01-30 10:18 ` [PATCH v5 5/6] security: keys: trusted: add ability to specify arbitrary policy James Bottomley
2020-01-30 10:18 ` [PATCH v5 6/6] security: keys: trusted: implement counter/timer policy James Bottomley
2020-02-20 20:17 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220201703.GA24990@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).