From: Jerry Snitselaar <jsnitsel@redhat.com>
To: "Loïc Yhuel" <loic.yhuel@gmail.com>
Cc: linux-integrity@vger.kernel.org, matthewgarrett@google.com,
ardb@kernel.org, jarkko.sakkinen@linux.intel.com,
javierm@redhat.com
Subject: Re: [PATCH] tpm: check event log version before reading final events
Date: Tue, 12 May 2020 11:45:53 -0700 [thread overview]
Message-ID: <20200512184553.to7zij2lhbqfnedp@cantor> (raw)
In-Reply-To: <20200512040113.277768-1-loic.yhuel@gmail.com>
On Tue May 12 20, Loïc Yhuel wrote:
>This fixes the boot issues since 5.3 on several Dell models when the TPM
>is enabled. Depending on the exact grub binary, booting the kernel would
>freeze early, or just report an error parsing the final events log.
>
>We get an event log in the SHA-1 format, which doesn't have a
>tcg_efi_specid_event_head in the first event, and there is a final events
>table which doesn't match the crypto agile format.
>__calc_tpm2_event_size reads bad "count" and "efispecid->num_algs", and
>either fails, or loops long enough for the machine to be appear frozen.
>
>So we now only parse the final events table, which is per the spec always
>supposed to be in the crypto agile format, when we got a event log in this
>format.
>
>Fixes: c46f3405692de ("tpm: Reserve the TPM final events table")
>Fixes: 166a2809d65b2 ("tpm: Don't duplicate events from the final event log in the TCG2 log")
>Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1779611
>Signed-off-by: Loïc Yhuel <loic.yhuel@gmail.com>
>---
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
next prev parent reply other threads:[~2020-05-12 18:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 4:01 [PATCH] tpm: check event log version before reading final events Loïc Yhuel
2020-05-12 6:44 ` Ard Biesheuvel
2020-05-12 11:40 ` Loïc Yhuel
2020-05-12 12:30 ` Ard Biesheuvel
2020-05-14 10:51 ` Jarkko Sakkinen
2020-05-14 1:09 ` Jarkko Sakkinen
2020-05-14 8:10 ` Ard Biesheuvel
2020-05-14 23:44 ` Jarkko Sakkinen
2020-05-12 17:45 ` Javier Martinez Canillas
2020-05-12 18:45 ` Jerry Snitselaar [this message]
2020-05-12 20:08 ` Matthew Garrett
2020-05-14 10:53 ` Jarkko Sakkinen
2020-05-14 11:28 ` Loïc Yhuel
2020-05-14 11:31 ` Ard Biesheuvel
2020-05-15 0:03 ` Jarkko Sakkinen
2020-05-14 11:33 ` Javier Martinez Canillas
2020-05-14 12:28 ` Ard Biesheuvel
2020-05-14 12:56 ` Javier Martinez Canillas
2020-05-14 13:04 ` Ard Biesheuvel
2020-05-14 13:51 ` Javier Martinez Canillas
2020-05-14 18:06 ` Matthew Garrett
2020-05-15 15:55 ` Loïc Yhuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512184553.to7zij2lhbqfnedp@cantor \
--to=jsnitsel@redhat.com \
--cc=ardb@kernel.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=loic.yhuel@gmail.com \
--cc=matthewgarrett@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).