From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Shuah Khan <shuah@kernel.org>
Cc: pengfei.xu@intel.com,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
stable@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Nikita Sobolev <Nikita.Sobolev@synopsys.com>,
Petr Vorel <petr.vorel@gmail.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/3] Revert "tpm: selftest: cleanup after unseal with wrong auth/policy test"
Date: Tue, 23 Jun 2020 00:20:20 +0300 [thread overview]
Message-ID: <20200622212034.20624-2-jarkko.sakkinen@linux.intel.com> (raw)
In-Reply-To: <20200622212034.20624-1-jarkko.sakkinen@linux.intel.com>
The reverted commit illegitly uses tpm2-tools. External dependencies are
absolutely forbidden from these tests. There is also the problem that
clearing is not necessarily wanted behavior if the test/target computer is
not used only solely for testing.
Fixes: a9920d3bad40 ("tpm: selftest: cleanup after unseal with wrong auth/policy test")
Cc: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: stable@vger.kernel.org
Cc: linux-integrity@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
tools/testing/selftests/tpm2/test_smoke.sh | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh
index 663062701d5a..79f8e9da5d21 100755
--- a/tools/testing/selftests/tpm2/test_smoke.sh
+++ b/tools/testing/selftests/tpm2/test_smoke.sh
@@ -8,8 +8,3 @@ ksft_skip=4
python -m unittest -v tpm2_tests.SmokeTest
python -m unittest -v tpm2_tests.AsyncTest
-
-CLEAR_CMD=$(which tpm2_clear)
-if [ -n $CLEAR_CMD ]; then
- tpm2_clear -T device
-fi
--
2.25.1
next parent reply other threads:[~2020-06-22 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200622212034.20624-1-jarkko.sakkinen@linux.intel.com>
2020-06-22 21:20 ` Jarkko Sakkinen [this message]
2020-06-22 21:20 ` [PATCH 2/3] selftests: tpm: Use 'test -e' instead of 'test -f' Jarkko Sakkinen
2020-06-22 21:20 ` [PATCH 3/3] selftests: tpm: Use /bin/sh instead of /bin/bash Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622212034.20624-2-jarkko.sakkinen@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Nikita.Sobolev@synopsys.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pengfei.xu@intel.com \
--cc=petr.vorel@gmail.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).