From: Arnd Bergmann <arnd@kernel.org>
To: Mimi Zohar <zohar@linux.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Stefan Berger <stefanb@linux.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
John Johansen <john.johansen@canonical.com>,
Tyler Hicks <tyhicks@linux.microsoft.com>,
Bruno Meneguele <bmeneg@redhat.com>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE_MODSIG
Date: Thu, 22 Apr 2021 15:29:48 +0200 [thread overview]
Message-ID: <20210422132956.1628059-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
When module support is disabled, CONFIG_MODULE_SIG_HASH cannot
be set either, so the build process fails with an error
certs/Makefile:52: *** Could not determine digest type to use from kernel config. Stop.
when IMA_APPRAISE_MODSIG is set but modules are not.
Add a Kconfig dependency to prevent this configuration.
Fixes: 0165f4ca223b ("ima: enable signing of modules with build time generated key")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
security/integrity/ima/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
index 12e9250c1bec..2c36144cdd24 100644
--- a/security/integrity/ima/Kconfig
+++ b/security/integrity/ima/Kconfig
@@ -242,6 +242,7 @@ config IMA_APPRAISE_MODSIG
bool "Support module-style signatures for appraisal"
depends on IMA_APPRAISE
depends on INTEGRITY_ASYMMETRIC_KEYS
+ depends on MODULES
select PKCS7_MESSAGE_PARSER
select MODULE_SIG_FORMAT
default n
--
2.29.2
next reply other threads:[~2021-04-22 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 13:29 Arnd Bergmann [this message]
2021-04-22 17:23 ` [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE_MODSIG Nayna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422132956.1628059-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=bmeneg@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=grandmaster@al2klimov.de \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=stefanb@linux.ibm.com \
--cc=tyhicks@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).