From: Stephen Boyd <swboyd@chromium.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Andrey Pronin <apronin@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Alexander Steffen <Alexander.Steffen@infineon.com>
Subject: Re: [PATCH v3 2/4] tpm: tpm_tis_spi: Export functionality to other drivers
Date: Mon, 12 Aug 2019 07:16:13 -0700 [thread overview]
Message-ID: <5d5174ae.1c69fb81.85930.8e93@mx.google.com> (raw)
In-Reply-To: <f441fd9a5452bf2943e5dbe6d74b5d5f26016a90.camel@linux.intel.com>
Quoting Jarkko Sakkinen (2019-08-09 13:28:13)
> On Tue, 2019-08-06 at 15:07 -0700, Stephen Boyd wrote:
> > We want to use most of the code in this driver, except we want to modify
> > the flow control and idle behavior. Let's "libify" this driver so that
> > another driver can call the code in here and slightly tweak the
> > behavior.
>
> Neither "libifying" nor "slightly tweaking" gives an idea what the
> commit does. A great commit message should be in imperative form
> describe what it does and why in as plain english as possible.
>
> Often commit messages are seen just as a necessary bad and not much
> energy is spent on them but for a maitainer solid commit messages have
> an indispensable value.
>
> > + void (*pre_transfer)(struct tpm_tis_spi_phy *phy);
>
> Adding a new calback should be a commit of its own.
>
Ok. I will do that and focus the commit message.
next prev parent reply other threads:[~2019-08-12 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 22:07 [PATCH v3 0/4] tpm: Add driver for cr50 Stephen Boyd
2019-08-06 22:07 ` [PATCH v3 1/4] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-08-09 18:02 ` Jarkko Sakkinen
2019-08-12 14:11 ` Stephen Boyd
2019-08-06 22:07 ` [PATCH v3 2/4] tpm: tpm_tis_spi: Export functionality to other drivers Stephen Boyd
2019-08-09 20:28 ` Jarkko Sakkinen
2019-08-12 14:16 ` Stephen Boyd [this message]
2019-08-06 22:07 ` [PATCH v3 3/4] dt-bindings: tpm: document properties for cr50 Stephen Boyd
2019-08-06 22:07 ` [PATCH v3 4/4] tpm: add driver for cr50 on SPI Stephen Boyd
2019-08-09 20:31 ` Jarkko Sakkinen
2019-08-12 20:46 ` Stephen Boyd
2019-08-15 13:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5174ae.1c69fb81.85930.8e93@mx.google.com \
--to=swboyd@chromium.org \
--cc=Alexander.Steffen@infineon.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).