From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Nayna Jain <nayna@linux.vnet.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>,
linuxppc-dev@ozlabs.org, linux-efi@vger.kernel.org,
linux-integrity@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jeremy Kerr <jk@ozlabs.org>,
Matthew Garret <matthew.garret@nebula.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Claudio Carvalho <cclaudio@linux.ibm.com>,
George Wilson <gcwilson@linux.ibm.com>,
Elaine Palmer <erpalmer@us.ibm.com>,
Eric Ricther <erichte@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Prakhar Srivastava <prsriva02@gmail.com>
Subject: Re: [PATCH v9 5/8] ima: make process_buffer_measurement() generic
Date: Fri, 25 Oct 2019 10:32:53 -0700 [thread overview]
Message-ID: <8a97301a-0e25-2718-bd81-d778cb58e1d3@linux.microsoft.com> (raw)
In-Reply-To: <24cf44d5-a1f0-f59e-9884-c026b1ee2d3b@linux.vnet.ibm.com>
On 10/25/2019 10:24 AM, Nayna Jain wrote:
>
> On 10/24/19 10:20 AM, Lakshmi Ramasubramanian wrote:
>> On 10/23/19 8:47 PM, Nayna Jain wrote:
>>
>> Hi Nayna,
>>
>>> +void process_buffer_measurement(const void *buf, int size,
>>> + const char *eventname, enum ima_hooks func,
>>> + int pcr)
>>> {
>>> int ret = 0;
>>> struct ima_template_entry *entry = NULL;
>>
>>> + if (func) {
>>> + security_task_getsecid(current, &secid);
>>> + action = ima_get_action(NULL, current_cred(), secid, 0, func,
>>> + &pcr, &template);
>>> + if (!(action & IMA_MEASURE))
>>> + return;
>>> + }
>>
>> In your change set process_buffer_measurement is called with NONE for
>> the parameter func. So ima_get_action (the above if block) will not be
>> executed.
>>
>> Wouldn't it better to update ima_get_action (and related functions) to
>> handle the ima policy (func param)?
>
>
> The idea is to use ima-buf template for the auxiliary measurement
> record. The auxiliary measurement record is an additional record to the
> one already created based on the existing policy. When func is passed as
> NONE, it represents it is an additional record. I am not sure what you
> mean by updating ima_get_action, it is already handling the ima policy.
>
I was referring to using "func" in process_buffer_measurement to
determine ima action. In my opinion, process_buffer_measurement should
be generic.
ima_get_action() should instead determine the required ima action,
template, pcr, etc. based on "func" passed to it.
thanks,
-lakshmi
next prev parent reply other threads:[~2019-10-25 17:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 3:47 [PATCH v9 0/8] powerpc: Enabling IMA arch specific secure boot policies Nayna Jain
2019-10-24 3:47 ` [PATCH v9 1/8] powerpc: detect the secure boot mode of the system Nayna Jain
2019-10-24 17:26 ` Lakshmi Ramasubramanian
2019-10-25 16:49 ` Nayna Jain
2019-10-24 3:47 ` [PATCH v9 2/8] powerpc/ima: add support to initialize ima policy rules Nayna Jain
2019-10-24 17:35 ` Lakshmi Ramasubramanian
2019-10-25 17:02 ` Nayna Jain
2019-10-25 18:03 ` Lakshmi Ramasubramanian
2019-10-28 23:42 ` Michael Ellerman
2019-10-26 23:52 ` Mimi Zohar
2019-10-28 11:54 ` Mimi Zohar
2019-10-24 3:47 ` [PATCH v9 3/8] powerpc: detect the trusted boot state of the system Nayna Jain
2019-10-24 17:38 ` Lakshmi Ramasubramanian
2019-10-25 16:50 ` Nayna Jain
2019-10-24 3:47 ` [PATCH v9 4/8] powerpc/ima: define trusted boot policy Nayna Jain
2019-10-24 17:40 ` Lakshmi Ramasubramanian
2019-10-24 3:47 ` [PATCH v9 5/8] ima: make process_buffer_measurement() generic Nayna Jain
2019-10-24 15:20 ` Lakshmi Ramasubramanian
2019-10-25 17:24 ` Nayna Jain
2019-10-25 17:32 ` Lakshmi Ramasubramanian [this message]
2019-10-27 0:13 ` Mimi Zohar
2019-10-30 15:22 ` Lakshmi Ramasubramanian
2019-10-30 16:35 ` Mimi Zohar
2019-10-24 3:47 ` [PATCH v9 6/8] certs: add wrapper function to check blacklisted binary hash Nayna Jain
2019-10-24 3:47 ` [PATCH v9 7/8] ima: check against blacklisted hashes for files with modsig Nayna Jain
2019-10-24 17:48 ` Lakshmi Ramasubramanian
2019-10-25 17:36 ` Nayna Jain
2019-10-24 3:47 ` [PATCH v9 8/8] powerpc/ima: update ima arch policy to check for blacklist Nayna Jain
2019-10-28 12:10 ` [PATCH v9 0/8] powerpc: Enabling IMA arch specific secure boot policies Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a97301a-0e25-2718-bd81-d778cb58e1d3@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=ard.biesheuvel@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=cclaudio@linux.ibm.com \
--cc=erichte@linux.ibm.com \
--cc=erpalmer@us.ibm.com \
--cc=gcwilson@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthew.garret@nebula.com \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=nayna@linux.vnet.ibm.com \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=prsriva02@gmail.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).