Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)

From: Paul Zimmerman <pauldzim@gmail.com>
To: Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)
Date: Tue, 19 Mar 2019 16:03:37 -0700	[thread overview]
Message-ID: <CADBGO7_XnbXiWHB=O1B_+b+CUA9g-bYJHN37VJ2SsxXMNHcPOQ@mail.gmail.com> (raw)
In-Reply-To: <CADBGO7-UkQMxSPdSX9bGVPxSRROj75FA16FuXeFrVmcKVQ_Qdg@mail.gmail.com>

So I bisected this down to:

# first bad commit: [a3fbfae82b4cb3ff9928e29f34c64d0507cad874] tpm:
take TPM chip power gating out of tpm_transmit()

but this doesn't revert cleanly on Linus' HEAD. Anyone have an idea what
could be wrong here?

Thanks,
-- Paul

On Mon, Mar 18, 2019 at 6:08 PM Paul Zimmerman <pauldzim@gmail.com> wrote:
>
> Hmm, looks like my original email didn't make it to the linux-integrity
> list, maybe the two attachments were too big. You can read it on the
> linux-kernel list here:
> https://marc.info/?l=linux-kernel&m=155294522323580
>
> On Mon, Mar 18, 2019 at 2:39 PM Paul Zimmerman <pauldzim@gmail.com> wrote:
> >
> > Hello,
> >
> > I'm seeing suspend-to-ram fail consistently in 5.1-rc1. Dmesg shows a
> > failure in the TPM subsystem. This is on an HP Elitebook 640 G1 running
> > Linux Mint.
> >
> > [   43.110604] wlo1: deauthenticating from 58:8b:f3:44:8f:5c by local choice (Reason: 3=DEAUTH_LEAVING)
> > [   53.179672] PM: suspend entry (deep)
> > [   53.179674] PM: Syncing filesystems ... done.
> > [   53.190349] Freezing user space processes ... (elapsed 0.001 seconds) done.
> > [   53.192107] OOM killer disabled.
> > [   53.192107] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
> > [   53.193147] printk: Suspending console(s) (use no_console_suspend to debug)
> > [   53.209184] sd 2:0:0:0: [sdb] Synchronizing SCSI cache
> > [   53.213137] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> > [   53.214632] sd 0:0:0:0: [sda] Stopping disk
> > [   53.241598] tpm tpm0: tpm_try_transmit: send(): error -5
> > [   53.241600] tpm tpm0: Error (-5) sending savestate before suspend
> > [   53.241606] PM: __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x90 returns -5
> > [   53.241609] PM: dpm_run_callback(): pnp_bus_suspend+0x0/0x20 returns -5
> > [   53.241610] PM: Device 00:06 failed to suspend: error -5
> >
> > Full dmesg and config attached. Anything I can do to help debug this?
> > It takes about 45 minutes to do a full kernel rebuild on this machine,
> > so doing a full bisection would be a little painful.
> >
> > -- Paul