From: Sumit Garg <sumit.garg@linaro.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Jerome Forissier <jerome@forissier.org>,
Maxim Uvarov <maxim.uvarov@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Arnd Bergmann <arnd@linaro.org>,
"tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, peterhuewe@gmx.de
Subject: Re: [Tee-dev] [PATCHv8 1/3] optee: use uuid for sysfs driver entry
Date: Thu, 25 Jun 2020 19:54:18 +0530 [thread overview]
Message-ID: <CAFA6WYMF+JjrB9Cx9TdgDzMeQSvPZfMNapzD-MH4ALVoUoo1sQ@mail.gmail.com> (raw)
In-Reply-To: <1593012069.28403.11.camel@HansenPartnership.com>
On Wed, 24 Jun 2020 at 20:51, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> On Wed, 2020-06-24 at 16:17 +0530, Sumit Garg wrote:
> > Apologies for delay in my reply as I was busy with some other stuff.
> >
> > On Fri, 19 Jun 2020 at 20:30, James Bottomley
> > <James.Bottomley@hansenpartnership.com> wrote:
> [...]
> > > it's about consistency with what the kernel types mean. When some
> > > checker detects your using little endian operations on a big endian
> > > structure (like in the prink for instance) they're going to keep
> > > emailing you about it.
> >
> > As mentioned above, using different terminology is meant to cause
> > more confusion than just difference in endianness which is manageable
> > inside TEE.
> >
> > And I think it's safe to say that the kernel implements UUID in big
> > endian format and thus uses %pUb whereas OP-TEE implements UUID in
> > little endian format and thus uses %pUl.
>
> So what I think you're saying is that if we still had uuid_be and
> uuid_le you'd use uuid_le, because that's exactly the structure
> described in the docs. But because we renamed
>
> uuid_be -> uuid_t
> uuid_le -> guid_t
>
> You can't use guid_t as a kernel type because it has the wrong name?
Isn't the rename commit description [1] pretty clear about which is
the true UUID type from Linux point of view?
[1]
commit f9727a17db9bab71ddae91f74f11a8a2f9a0ece6
Author: Christoph Hellwig <hch@lst.de>
Date: Wed May 17 10:02:48 2017 +0200
uuid: rename uuid types
Our "little endian" UUID really is a Wintel GUID, so rename it and its
helpers such (guid_t). The big endian UUID is the **only true** one, so
give it the name uuid_t. The uuid_le and uuid_be names are retained for
now, but will hopefully go away soon. The exception to that are the _cmp
helpers that will be replaced by better primitives ASAP and thus don't
get the new names.
Also the _to_bin helpers are named to match the better named uuid_parse
routine in userspace.
Also remove the existing typedef in XFS that's now been superceeded by
the generic type name.
Signed-off-by: Christoph Hellwig <hch@lst.de>
[andy: also update the UUID_LE/UUID_BE macros including fallout]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
-Sumit
>
> James
>
next prev parent reply other threads:[~2020-06-25 14:24 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:58 [PATCHv8 0/3] optee: register drivers on optee bus Maxim Uvarov
2020-06-04 17:58 ` [PATCHv8 1/3] optee: use uuid for sysfs driver entry Maxim Uvarov
2020-06-16 20:50 ` Jarkko Sakkinen
2020-06-17 6:07 ` Sumit Garg
2020-06-17 6:45 ` Maxim Uvarov
2020-06-17 13:58 ` Sumit Garg
2020-06-17 14:12 ` Maxim Uvarov
2020-06-17 15:16 ` [Tee-dev] " Jerome Forissier
2020-06-17 19:52 ` Maxim Uvarov
2020-06-17 20:45 ` Jerome Forissier
2020-06-18 4:59 ` Sumit Garg
2020-06-18 5:12 ` Sumit Garg
2020-06-18 19:18 ` James Bottomley
2020-06-19 8:12 ` Sumit Garg
2020-06-19 15:00 ` James Bottomley
2020-06-24 9:50 ` Jens Wiklander
2020-06-24 10:47 ` Sumit Garg
2020-06-24 15:21 ` James Bottomley
2020-06-24 15:44 ` Jerome Forissier
2020-06-25 12:51 ` Maxim Uvarov
2020-06-26 5:13 ` Sumit Garg
2020-06-26 8:47 ` Andy Shevchenko
2020-06-26 5:26 ` Sumit Garg
2020-06-25 14:24 ` Sumit Garg [this message]
2020-06-25 23:31 ` James Bottomley
2020-06-26 5:10 ` Sumit Garg
2020-06-26 7:26 ` Sumit Garg
2020-06-26 11:29 ` Daniel Thompson
2020-06-26 15:11 ` James Bottomley
2020-06-29 6:55 ` Sumit Garg
2020-06-29 7:03 ` Jens Wiklander
2020-06-18 6:57 ` Jerome Forissier
2020-06-18 7:44 ` Maxim Uvarov
2020-06-04 17:58 ` [PATCHv8 2/3] optee: enable support for multi-stage bus enumeration Maxim Uvarov
2020-06-16 20:56 ` Jarkko Sakkinen
2020-06-04 17:58 ` [PATCHv8 3/3] tpm_ftpm_tee: register driver on TEE bus Maxim Uvarov
2020-06-16 20:57 ` Jarkko Sakkinen
2020-06-15 14:32 ` [PATCHv8 0/3] optee: register drivers on optee bus Maxim Uvarov
2020-06-16 8:29 ` Jens Wiklander
2020-06-17 14:26 ` Maxim Uvarov
2020-06-18 8:00 ` Jens Wiklander
2020-06-17 23:37 ` Jarkko Sakkinen
2020-06-18 7:56 ` Jens Wiklander
2020-06-23 0:50 ` Jarkko Sakkinen
2020-06-16 20:49 ` Jarkko Sakkinen
2020-06-16 20:54 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFA6WYMF+JjrB9Cx9TdgDzMeQSvPZfMNapzD-MH4ALVoUoo1sQ@mail.gmail.com \
--to=sumit.garg@linaro.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jerome@forissier.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.uvarov@linaro.org \
--cc=peterhuewe@gmx.de \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).