From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4AF4C48BD1 for ; Fri, 11 Jun 2021 09:11:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6B7461263 for ; Fri, 11 Jun 2021 09:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbhFKJNo (ORCPT ); Fri, 11 Jun 2021 05:13:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231266AbhFKJNn (ORCPT ); Fri, 11 Jun 2021 05:13:43 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9656DC0617AF for ; Fri, 11 Jun 2021 02:11:45 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id z8so5234697wrp.12 for ; Fri, 11 Jun 2021 02:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YElcP8wY/ItH22s2CX3Yk/qIGr089Bxcg+NXSKlpwwM=; b=woZ9K25EeoLQgFPoZVy3NGyq6fwzaVKAJZhft3QVaaHAwjel+T2FHYXKeJVF0dq4IV KT4si0PHrixQw5HW0jmWLmRYpEtsp3/eZfK1U1nrDfC+VhljAejz/6LwRdKB8Bvb2tMa H8J9YWPe2MRbFZbJXcHP9jn7fySM4WPSRK7A5F8GgRiy8AGIsgp23zFDTlJdWTDgJ7cW xXmc3PcmEMqJbvIehCJmyyOqmCmZDswRrH03zxLaBPaRmV2V5yqUL83Ikt6z3g2y/aXt ybc6xsaj2MgpPjXFU9ob9H9own759QmqW4hygFJqr/9Sgi2hbAlnjJGYMW/I5iO5C/CZ ycXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YElcP8wY/ItH22s2CX3Yk/qIGr089Bxcg+NXSKlpwwM=; b=ZBLIuLt0dpHewZnBTMHXSZGmtT1yVq6zin46I/LeGcSMuI49CH4jURjhzJJ1eS0ZsC BkHxdZh+gN/l3KQdzLRm8dqhv8dOaBRzcQwdemppCSIpTgG5x2vC6PNZPhgM8/v8mgpG PDGVb9wEqHPJhcrD/dKY+oZsHJ2pTIe6I2HMcxHVqncCIHoLCY9OWo1mJtEV9UkIJxBF ZIPpyD2TtxK+ePuJXqJbDlAEAscNcLwRkGDKuPsykmFuTxQjrl+OLaS44fF7Q1Z3Z7NA hxhf9xAmQeD0Y5YmcUPU2NWEI+ZFg1U6oAggtcQENlsrF9S0UO28EuOlz5DfWYOYb9DT Z+Lw== X-Gm-Message-State: AOAM533cIpY7DSmP70jXk7ZkT316MXQHaBeXBmx/9Yq4e1raf8BvxeL5 Fr6QhEmyiRTbNP8iZxLWLW3+GjRA9QulULmg/EE/og== X-Google-Smtp-Source: ABdhPJygoquYofYpaeSWf98r/mIW7k2U9CQBWHXDLqMaKoPkUUyF4l08eSJo3Yli8sYbBlkW2zzw2hVNtPKpLBXGTGc= X-Received: by 2002:a05:6000:229:: with SMTP id l9mr2803707wrz.43.1623402704237; Fri, 11 Jun 2021 02:11:44 -0700 (PDT) MIME-Version: 1.0 References: <20210610210913.536081-1-tyhicks@linux.microsoft.com> <20210610210913.536081-4-tyhicks@linux.microsoft.com> In-Reply-To: <20210610210913.536081-4-tyhicks@linux.microsoft.com> From: Jens Wiklander Date: Fri, 11 Jun 2021 11:11:33 +0200 Message-ID: Subject: Re: [PATCH v4 3/8] optee: fix tee out of memory failure seen during kexec reboot To: Tyler Hicks Cc: Allen Pais , Sumit Garg , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Vikas Gupta , Thirupathaiah Annapureddy , Pavel Tatashin , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , OP-TEE TrustedFirmware , linux-integrity , bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, Jun 10, 2021 at 11:09 PM Tyler Hicks wrote: > > From: Allen Pais > > The following out of memory errors are seen on kexec reboot > from the optee core. > > [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed > [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 > > tee_shm_release() is not invoked on dma shm buffer. > > Implement .shutdown() method to handle the release of the buffers > correctly. > > More info: > https://github.com/OP-TEE/optee_os/issues/3637 > > Signed-off-by: Allen Pais > Reviewed-by: Tyler Hicks Do we really need this considering the patch "optee: Refuse to load the driver under the kdump kernel"? Jens