From: Arnd Bergmann <arnd@arndb.de>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Christophe Ricard <christophe.ricard@gmail.com>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
gregkh <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] tpm: Fix the description error of the help information in Kconfig
Date: Mon, 27 Jul 2020 10:32:04 +0200 [thread overview]
Message-ID: <CAK8P3a0FkrTKvAgPi=tnsShK+=eysbfiRxUTqoxfs6SJVXXnpw@mail.gmail.com> (raw)
In-Reply-To: <20200727082245.32396-1-tianjia.zhang@linux.alibaba.com>
On Mon, Jul 27, 2020 at 10:22 AM Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
> SPI protocol standardized by the TCG is described in the TCG PTP
> specification 1.3 (chapter 6.4.6 SPI Bit Protocol), It was published by
> TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf.
I'm still not convinced you got this right, the document you cite only
seems to mention TPM 1.2 as the base for TIS 1.3, but not TPM 1.3.
Arnd
> The TPM version number in the help message is wrong, which will
> cause confusion. This patch fixes it.
>
> Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
> drivers/char/tpm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 58b4c573d176..8eedb3e704f3 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -62,7 +62,7 @@ config TCG_TIS_SPI
> help
> If you have a TPM security chip which is connected to a regular,
> non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
> - TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
> + TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
> specification (TPM2.0) say Yes and it will be accessible from
> within Linux. To compile this driver as a module, choose M here;
> the module will be called tpm_tis_spi.
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-07-27 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 8:22 [PATCH v2] tpm: Fix the description error of the help information in Kconfig Tianjia Zhang
2020-07-27 8:32 ` Arnd Bergmann [this message]
2020-07-28 12:33 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0FkrTKvAgPi=tnsShK+=eysbfiRxUTqoxfs6SJVXXnpw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=christophe.ricard@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).