From: Rob Herring <robh@kernel.org>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Cc: Mimi Zohar <zohar@linux.ibm.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>,
kbuild-all@lists.01.org,
clang-built-linux <clang-built-linux@googlegroups.com>,
linux-integrity@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
tusharsu@linux.microsoft.com
Subject: Re: [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer'
Date: Thu, 10 Jun 2021 12:34:18 -0500 [thread overview]
Message-ID: <CAL_JsqKcypxO+6X3MgjGGvBYELcOi34TjoscMMrkB4PApquuQQ@mail.gmail.com> (raw)
In-Reply-To: <20210610171553.3806-1-nramas@linux.microsoft.com>
On Thu, Jun 10, 2021 at 12:16 PM Lakshmi Ramasubramanian
<nramas@linux.microsoft.com> wrote:
>
> The function prototype for ima_add_kexec_buffer() is present
> in 'linux/ima.h'. But this header file is not included in
> ima_kexec.c where the function is implemented. This results
> in the following compiler warning when "-Wmissing-prototypes" flag
> is turned on:
>
> security/integrity/ima/ima_kexec.c:81:6: warning: no previous prototype
> for function 'ima_add_kexec_buffer' [-Wmissing-prototypes]
>
> Include the header file 'linux/ima.h' in ima_kexec.c to fix
> the compiler warning.
>
> Fixes: dce92f6b11c3 (arm64: Enable passing IMA log to next kernel on kexec)
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> ---
> security/integrity/ima/ima_kexec.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-06-10 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 17:15 [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Lakshmi Ramasubramanian
2021-06-10 17:15 ` [PATCH 2/2] ima: Fix warning: no previous prototype for function 'ima_post_key_create_or_update' Lakshmi Ramasubramanian
2021-06-10 17:36 ` Rob Herring
2021-06-11 1:24 ` Mimi Zohar
2021-06-10 17:34 ` Rob Herring [this message]
2021-06-11 15:41 ` [PATCH 1/2] ima: Fix warning: no previous prototype for function 'ima_add_kexec_buffer' Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKcypxO+6X3MgjGGvBYELcOi34TjoscMMrkB4PApquuQQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=bauerman@linux.ibm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=tusharsu@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).