From: Chuck Lever <chuck.lever@oracle.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 3/5] NFSD: Remove ima_file_check call
Date: Fri, 8 Mar 2019 16:11:06 -0500 [thread overview]
Message-ID: <ECE4FD20-840C-4047-9454-27BDF0A905EA@oracle.com> (raw)
In-Reply-To: <20190308211016.GB27011@fieldses.org>
> On Mar 8, 2019, at 4:10 PM, bfields@fieldses.org wrote:
>
> On Thu, Mar 07, 2019 at 10:28:54AM -0500, Chuck Lever wrote:
>> The NFS server needs to allow NFS clients to perform their own
>> attestation and measurement.
>
> Can we really remove this call?
Why wouldn't we be able to?
> --b.
>
>>
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
>> fs/nfsd/vfs.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
>> index 3c00072..524c6e5 100644
>> --- a/fs/nfsd/vfs.c
>> +++ b/fs/nfsd/vfs.c
>> @@ -802,12 +802,6 @@ static int nfsd_open_break_lease(struct inode *inode, int access)
>> goto out_nfserr;
>> }
>>
>> - host_err = ima_file_check(file, may_flags);
>> - if (host_err) {
>> - fput(file);
>> - goto out_nfserr;
>> - }
>> -
>> if (may_flags & NFSD_MAY_64BIT_COOKIE)
>> file->f_mode |= FMODE_64BITHASH;
>> else
--
Chuck Lever
next prev parent reply other threads:[~2019-03-08 21:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 15:28 [PATCH v2 0/5] RFC: Linux IMA on NFS prototype Chuck Lever
2019-03-07 15:28 ` [PATCH v2 1/5] NFS: Define common IMA-related protocol elements Chuck Lever
2019-03-07 15:28 ` [PATCH v2 2/5] NFSD: Prototype support for IMA on NFS (server) Chuck Lever
2019-03-07 15:28 ` [PATCH v2 3/5] NFSD: Remove ima_file_check call Chuck Lever
2019-03-08 21:10 ` J. Bruce Fields
2019-03-08 21:11 ` Chuck Lever [this message]
2019-03-08 21:23 ` Bruce Fields
2019-03-08 21:29 ` Chuck Lever
2019-03-19 20:29 ` Mimi Zohar
2019-03-20 13:40 ` Chuck Lever
2019-03-21 11:44 ` Mimi Zohar
2019-03-21 14:04 ` Chuck Lever
2019-03-22 22:55 ` Mimi Zohar
2019-03-25 14:24 ` Chuck Lever
2019-03-25 15:01 ` Mimi Zohar
2019-03-07 15:28 ` [PATCH v2 4/5] NFS: Rename security xattr handler Chuck Lever
2019-03-07 15:29 ` [PATCH v2 5/5] NFS: Prototype support for IMA on NFS (client) Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ECE4FD20-840C-4047-9454-27BDF0A905EA@oracle.com \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).