From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
James Bottomley <jejb@linux.ibm.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Mimi Zohar <zohar@linuxibm.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: use tab instead of spaces
Date: Mon, 11 Feb 2019 16:14:12 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1902111610380.2831@alpaca> (raw)
In-Reply-To: <7befaea3d1a86950f9dd270fed47072214fa2876.camel@perches.com>
iOn Sun, 10 Feb 2019, Joe Perches wrote:
> On Sun, 2019-02-10 at 19:10 +0100, Lukas Bulwahn wrote:
> > Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as
> > further maintainer to the KEYS-TRUSTED section entry. So, we rectify this
> > with this commit.
> >
> > The issue was detected when writing a script that parses MAINTAINERS.
>
> checkpatch already does that btw:
Good to know.
>
> $ ./scripts/checkpatch.pl -f MAINTAINERS
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #8408: FILE: MAINTAINERS:8408:
> +M: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #12607: FILE: MAINTAINERS:12607:
> +M: Ilia Lin <ilia.lin@gmail.com>
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #12608: FILE: MAINTAINERS:12608:
> +L: linux-pm@vger.kernel.org
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #12609: FILE: MAINTAINERS:12609:
> +S: Maintained
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #12610: FILE: MAINTAINERS:12610:
> +F: Documentation/devicetree/bindings/opp/kryo-cpufreq.txt
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #12611: FILE: MAINTAINERS:12611:
> +F: drivers/cpufreq/qcom-cpufreq-kryo.c
>
> total: 0 errors, 6 warnings, 16993 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace
>
On next-20190211, the checkpatch issues in line 12607 to 12611 are not
reported anymore, as I already fixed them in commit 70e6e7d92bca
("MAINTAINERS: use common indentation").
So, the issue addressed here and in the later follow-up patch is the only
style-related issue in MAINTAINERS.
After that, everything in MAINTAINERS is stylistically clean.
Lukas
prev parent reply other threads:[~2019-02-11 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 18:10 [PATCH] MAINTAINERS: use tab instead of spaces Lukas Bulwahn
2019-02-10 18:21 ` Randy Dunlap
2019-02-10 18:30 ` Lukas Bulwahn
2019-02-10 18:25 ` James Bottomley
2019-02-10 19:06 ` lukas.bulwahn
2019-02-11 2:21 ` Joe Perches
2019-02-11 1:54 ` Joe Perches
2019-02-11 15:14 ` Lukas Bulwahn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1902111610380.2831@alpaca \
--to=lukas.bulwahn@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jejb@linux.ibm.com \
--cc=joe@perches.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linuxibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).