From: Igor Stoppa <igor.stoppa@gmail.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Matthew Wilcox <willy@infradead.org>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
igor.stoppa@huawei.com, Nadav Amit <nadav.amit@gmail.com>,
Kees Cook <keescook@chromium.org>,
linux-integrity@vger.kernel.org,
kernel-hardening@lists.openwall.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] IMA: turn ima_policy_flags into __wr_after_init
Date: Thu, 20 Dec 2018 19:49:52 +0200 [thread overview]
Message-ID: <bb8cb502-d958-c4b4-eb82-603799079b63@gmail.com> (raw)
In-Reply-To: <87pntwumw6.fsf@morokweng.localdomain>
Hi,
On 20/12/2018 19:30, Thiago Jung Bauermann wrote:
>
> Hello Igor,
>
> Igor Stoppa <igor.stoppa@gmail.com> writes:
>
>> diff --git a/security/integrity/ima/ima_init.c b/security/integrity/ima/ima_init.c
>> index 59d834219cd6..5f4e13e671bf 100644
>> --- a/security/integrity/ima/ima_init.c
>> +++ b/security/integrity/ima/ima_init.c
>> @@ -21,6 +21,7 @@
>> #include <linux/scatterlist.h>
>> #include <linux/slab.h>
>> #include <linux/err.h>
>> +#include <linux/prmem.h>
>>
>> #include "ima.h"
>>
>> @@ -98,9 +99,9 @@ void __init ima_load_x509(void)
>> {
>> int unset_flags = ima_policy_flag & IMA_APPRAISE;
>>
>> - ima_policy_flag &= ~unset_flags;
>> + wr_assign(ima_policy_flag, ima_policy_flag & ~unset_flags);
>> integrity_load_x509(INTEGRITY_KEYRING_IMA, CONFIG_IMA_X509_PATH);
>> - ima_policy_flag |= unset_flags;
>> + wr_assign(ima_policy_flag, ima_policy_flag | unset_flags);
>> }
>> #endif
>
> In the cover letter, you said:
>
>> As the name implies, the write protection kicks in only after init()
>> is completed; before that moment, the data is modifiable in the usual
>> way.
>
> Given that, is it still necessary or useful to use wr_assign() in a
> function marked with __init?
I might have been over enthusiastic of using the wr interface.
You are right, I can drop these two. Thank you.
--
igor
next prev parent reply other threads:[~2018-12-20 17:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 21:33 [RFC v2 PATCH 0/12] hardening: statically allocated protected memory Igor Stoppa
2018-12-19 21:33 ` [PATCH 01/12] x86_64: memset_user() Igor Stoppa
2018-12-19 21:33 ` [PATCH 02/12] __wr_after_init: linker section and label Igor Stoppa
2018-12-19 21:33 ` [PATCH 03/12] __wr_after_init: generic header Igor Stoppa
2018-12-21 19:38 ` Nadav Amit
2018-12-21 19:45 ` Matthew Wilcox
2018-12-23 2:28 ` Igor Stoppa
2018-12-19 21:33 ` [PATCH 04/12] __wr_after_init: x86_64: __wr_op Igor Stoppa
2018-12-20 16:53 ` Igor Stoppa
2018-12-20 17:20 ` Thiago Jung Bauermann
2018-12-20 17:46 ` Igor Stoppa
2018-12-20 18:49 ` Matthew Wilcox
2018-12-20 19:19 ` Igor Stoppa
2018-12-20 19:27 ` Matthew Wilcox
2018-12-21 17:23 ` Andy Lutomirski
2018-12-21 17:42 ` Igor Stoppa
2018-12-19 21:33 ` [PATCH 05/12] __wr_after_init: x86_64: debug writes Igor Stoppa
2018-12-19 21:33 ` [PATCH 06/12] __wr_after_init: Documentation: self-protection Igor Stoppa
2018-12-19 21:33 ` [PATCH 07/12] __wr_after_init: lkdtm test Igor Stoppa
2018-12-19 21:33 ` [PATCH 08/12] rodata_test: refactor tests Igor Stoppa
2018-12-19 21:33 ` [PATCH 09/12] rodata_test: add verification for __wr_after_init Igor Stoppa
2018-12-19 21:33 ` [PATCH 10/12] __wr_after_init: test write rare functionality Igor Stoppa
2018-12-19 21:33 ` [PATCH 11/12] IMA: turn ima_policy_flags into __wr_after_init Igor Stoppa
2018-12-20 17:30 ` Thiago Jung Bauermann
2018-12-20 17:49 ` Igor Stoppa [this message]
2018-12-19 21:33 ` [PATCH 12/12] x86_64: __clear_user as case of __memset_user Igor Stoppa
[not found] <20181221181423.20455-1-igor.stoppa@huawei.com>
2018-12-21 18:14 ` [PATCH 11/12] IMA: turn ima_policy_flags into __wr_after_init Igor Stoppa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb8cb502-d958-c4b4-eb82-603799079b63@gmail.com \
--to=igor.stoppa@gmail.com \
--cc=bauerman@linux.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=igor.stoppa@huawei.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=nadav.amit@gmail.com \
--cc=peterz@infradead.org \
--cc=willy@infradead.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).