From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, PeterHuewe@gmx.de,
jgg@ziepe.ca
Subject: Re: [PATCH v2 2/2] selftests/tpm2: Extend tests to cover partial reads
Date: Wed, 13 Feb 2019 08:27:44 -0800 [thread overview]
Message-ID: <dc02e064-9c95-cb51-60d8-4a6219f77430@intel.com> (raw)
In-Reply-To: <9d3e78706b2fdbe0427f675592df5d7920d2c030.camel@linux.intel.com>
On 2/13/19 7:13 AM, Jarkko Sakkinen wrote:
> On Tue, 2019-02-12 at 15:42 -0800, Tadeusz Struk wrote:
>> Three new tests added:
>> 1. Send get random cmd, read header in 1st read, read the rest in second
>> read - expect success
>> 2. Send get random cmd, read only part of the response, send another
>> get random command, read the response - expect success
>> 3. Send get random cmd followed by another get random cmd, without
>> reading the first response - expect the second cmd to fail with -EBUSY
>>
>> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
>
> Getting still some garbage in the output:
>
> $ sudo ./test_smoke.sh
> [sudo] password for jsakkine:
> test_read_partial_overwrite (tpm2_tests.SmokeTest)
> Reads only part of the response and issue a new cmd ... ok
> test_read_partial_resp (tpm2_tests.SmokeTest)
> Reads random in two subsequent reads ... ok
> test_seal_with_auth (tpm2_tests.SmokeTest) ... ok
> test_seal_with_policy (tpm2_tests.SmokeTest) ... ok
> test_seal_with_too_long_auth (tpm2_tests.SmokeTest) ... ok
> test_send_two_cmds (tpm2_tests.SmokeTest)
> Send two cmds without reading a response ... ok
> test_too_short_cmd (tpm2_tests.SmokeTest) ... ok
> test_unseal_with_wrong_auth (tpm2_tests.SmokeTest) ... ok
> test_unseal_with_wrong_policy (tpm2_tests.SmokeTest) ... ok
Looks like python unittest prints out the docstrings:
+ def test_read_partial_resp(self):
+ """Reads random in two subsequent reads"""
I can remove them if it makes more difficult to process the output.
Thanks,
--
Tadeusz
next prev parent reply other threads:[~2019-02-13 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 23:42 [PATCH v2 1/2] selftests/tpm2: Open tpm dev in unbuffered mode Tadeusz Struk
2019-02-12 23:42 ` [PATCH v2 2/2] selftests/tpm2: Extend tests to cover partial reads Tadeusz Struk
2019-02-13 15:13 ` Jarkko Sakkinen
2019-02-13 16:27 ` Tadeusz Struk [this message]
2019-02-13 16:33 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc02e064-9c95-cb51-60d8-4a6219f77430@intel.com \
--to=tadeusz.struk@intel.com \
--cc=PeterHuewe@gmx.de \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).