From: Milan Broz <gmazyland@gmail.com>
To: Mike Snitzer <snitzer@redhat.com>,
Jaskaran Khurana <jaskarankhurana@linux.microsoft.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-fsdevel@vger.kernel.org, scottsh@microsoft.com,
ebiggers@google.com, jmorris@namei.org, dm-devel@redhat.com,
mpatocka@redhat.com, agk@redhat.com
Subject: Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.
Date: Wed, 26 Jun 2019 07:48:49 +0200 [thread overview]
Message-ID: <e0cb17cc-35f9-46e2-ca1a-1c942989ed20@gmail.com> (raw)
In-Reply-To: <20190625182004.GA32075@redhat.com>
On 25/06/2019 20:20, Mike Snitzer wrote:
> On Wed, Jun 19 2019 at 3:10pm -0400,
> Jaskaran Khurana <jaskarankhurana@linux.microsoft.com> wrote:
>
>> The verification is to support cases where the roothash is not secured by
>> Trusted Boot, UEFI Secureboot or similar technologies.
>> One of the use cases for this is for dm-verity volumes mounted after boot,
>> the root hash provided during the creation of the dm-verity volume has to
>> be secure and thus in-kernel validation implemented here will be used
>> before we trust the root hash and allow the block device to be created.
>>
>> The signature being provided for verification must verify the root hash and
>> must be trusted by the builtin keyring for verification to succeed.
>>
>> The hash is added as a key of type "user" and the description is passed to
>> the kernel so it can look it up and use it for verification.
>>
>> Kernel commandline parameter will indicate whether to check (only if
>> specified) or force (for all dm verity volumes) roothash signature
>> verification.
>>
>> Kernel commandline: dm_verity.verify_sig=1 or 2 for check/force root hash
>> signature validation respectively.
>>
>> Signed-off-by: Jaskaran Khurana <jaskarankhurana@linux.microsoft.com>
>
> Milan and/or others: could you please provide review and if you're OK
> with this patch respond accordingly?
Stand by please :)
I like the patch, I think all major problems were solved, but I still need to test it somehow.
Anyway, for the time being, I keep all ongoing patches that need some later
userspace support in my branch
https://git.kernel.org/pub/scm/linux/kernel/git/mbroz/linux.git/log/?h=dm-cryptsetup
so at least it get some automated testing.
Milan
next prev parent reply other threads:[~2019-06-26 5:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 19:10 [RFC PATCH v5 0/1] Add dm verity root hash pkcs7 sig validation Jaskaran Khurana
2019-06-19 19:10 ` [RFC PATCH v5 1/1] " Jaskaran Khurana
2019-06-25 18:20 ` Mike Snitzer
2019-06-26 5:48 ` Milan Broz [this message]
2019-08-13 18:49 ` Jaskaran Singh Khurana
2019-06-27 12:17 ` Milan Broz
2019-06-28 1:52 ` Jaskaran Singh Khurana
2019-06-27 23:41 ` Eric Biggers
2019-06-28 1:49 ` Jaskaran Singh Khurana
2019-06-28 3:00 ` Eric Biggers
2019-06-28 5:12 ` Milan Broz
2019-06-28 17:03 ` Jaskaran Singh Khurana
2019-06-28 4:00 ` [RFC PATCH v5 0/1] " Eric Biggers
2019-06-28 19:45 ` Jaskaran Singh Khurana
2019-06-28 20:34 ` Eric Biggers
2019-06-28 23:27 ` Jaskaran Singh Khurana
2019-06-29 4:01 ` James Morris
2019-07-01 9:41 ` Milan Broz
2019-07-01 17:33 ` Jaskaran Singh Khurana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0cb17cc-35f9-46e2-ca1a-1c942989ed20@gmail.com \
--to=gmazyland@gmail.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=jaskarankhurana@linux.microsoft.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=scottsh@microsoft.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).