From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2768CC31E53 for ; Mon, 17 Jun 2019 08:34:16 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08B1C2238D for ; Mon, 17 Jun 2019 08:34:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B1C2238D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id B92E4C3E; Mon, 17 Jun 2019 08:34:15 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7DFC7C3A for ; Mon, 17 Jun 2019 08:34:14 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 23531828 for ; Mon, 17 Jun 2019 08:34:14 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id D530F68D0E; Mon, 17 Jun 2019 10:33:42 +0200 (CEST) Date: Mon, 17 Jun 2019 10:33:42 +0200 From: Christoph Hellwig To: Dan Carpenter Subject: Re: use exact allocation for dma coherent memory Message-ID: <20190617083342.GA7883@lst.de> References: <20190614134726.3827-1-hch@lst.de> <20190617082148.GF28859@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190617082148.GF28859@kadam> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Maxime Ripard , Joonas Lahtinen , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, David Airlie , linux-media@vger.kernel.org, Intel Linux Wireless , intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Jani Nikula , Ian Abbott , Rodrigo Vivi , Sean Paul , "moderated list:ARM PORT" , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, H Hartley Sweeten , iommu@lists.linux-foundation.org, Daniel Vetter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org > drivers/infiniband/hw/cxgb4/qp.c > 129 static int alloc_host_sq(struct c4iw_rdev *rdev, struct t4_sq *sq) > 130 { > 131 sq->queue = dma_alloc_coherent(&(rdev->lldi.pdev->dev), sq->memsize, > 132 &(sq->dma_addr), GFP_KERNEL); > 133 if (!sq->queue) > 134 return -ENOMEM; > 135 sq->phys_addr = virt_to_phys(sq->queue); > 136 dma_unmap_addr_set(sq, mapping, sq->dma_addr); > 137 return 0; > 138 } > > Is this a bug? Yes. This will blow up badly on many platforms, as sq->queue might be vmapped, ioremapped, come from a pool without page backing. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu