From: Daniel Drake <drake@endlessm.com>
To: joro@8bytes.org
Cc: heiko@sntech.de, bjorn.andersson@linaro.org,
linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
will@kernel.org, jean-philippe@linaro.org,
linux-samsung-soc@vger.kernel.org, krzk@kernel.org,
jonathanh@nvidia.com, linux-rockchip@lists.infradead.org,
agross@kernel.org, jonathan.derrick@intel.com,
linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
virtualization@lists.linux-foundation.org,
gerald.schaefer@de.ibm.com, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
kgene@kernel.org, robin.murphy@arm.com
Subject: Re: [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code
Date: Fri, 17 Apr 2020 09:03:35 +0800 [thread overview]
Message-ID: <20200417010335.31739-1-drake@endlessm.com> (raw)
In-Reply-To: <20200414131542.25608-1-joro@8bytes.org>
Hi Joerg,
> Hi,
>
> here is the second version of this patch-set. The first version with
> some more introductory text can be found here:
>
> https://lore.kernel.org/lkml/20200407183742.4344-1-joro@8bytes.org/
Thanks for the continued improvements in this area!
I may have spotted a problem with setups like VMD.
The core PCI bus is set up during early boot.
Then, for the PCI bus, we reach iommu_bus_init() -> bus_iommu_probe().
In there, we call probe_iommu_group() -> dev_iommu_get() for each PCI
device, which allocates dev->iommu in each case. So far so good.
The problem is that this is the last time that we'll call dev_iommu_get().
If any PCI bus devices get added after this point, they do not get passed
to dev_iommu_get().
So when the vmd module gets loaded later, and creates more PCI devices,
we end up in iommu_bus_notifier() -> iommu_probe_device()
-> __iommu_probe_device() which does:
dev->iommu->iommu_dev = iommu_dev;
dev->iommu-> is a NULL dereference because dev_iommu_get() was never
called for this new device.
Daniel
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-17 1:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200414131600eucas1p16f1ff6aedb780eb795a770dc08e5dec5@eucas1p1.samsung.com>
2020-04-14 13:15 ` [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 01/33] iommu: Move default domain allocation to separate function Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 02/33] iommu: Add def_domain_type() callback in iommu_ops Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 03/33] iommu/amd: Implement iommu_ops->def_domain_type call-back Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 04/33] iommu/vt-d: Wire up iommu_ops->def_domain_type Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 05/33] iommu/amd: Remove dma_mask check from check_device() Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 06/33] iommu/amd: Return -ENODEV in add_device when device is not handled by IOMMU Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 07/33] iommu: Add probe_device() and remove_device() call-backs Joerg Roedel
2020-04-15 6:36 ` Lu Baolu
2020-04-15 12:31 ` Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 08/33] iommu: Move default domain allocation to iommu_probe_device() Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 09/33] iommu: Keep a list of allocated groups in __iommu_probe_device() Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 10/33] iommu: Move new probe_device path to separate function Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 11/33] iommu: Split off default domain allocation from group assignment Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 12/33] iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device() Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 13/33] iommu: Export bus_iommu_probe() and make is safe for re-probing Joerg Roedel
2020-04-15 6:10 ` Lu Baolu
2020-04-15 12:29 ` Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 14/33] iommu/amd: Remove dev_data->passthrough Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 15/33] iommu/amd: Convert to probe/release_device() call-backs Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 16/33] iommu/vt-d: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 17/33] iommu/arm-smmu: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 18/33] iommu/pamu: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 19/33] iommu/s390: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 20/33] iommu/virtio: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 21/33] iommu/msm: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 22/33] iommu/mediatek: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 23/33] iommu/mediatek-v1 " Joerg Roedel
2020-05-15 7:44 ` Yong Wu
2020-05-15 10:07 ` Joerg Roedel
2020-05-18 6:51 ` Yong Wu
2020-05-18 13:55 ` Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 24/33] iommu/qcom: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 25/33] iommu/rockchip: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 26/33] iommu/tegra: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 27/33] iommu/renesas: " Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 28/33] iommu/omap: Remove orphan_dev tracking Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 29/33] iommu/omap: Convert to probe/release_device() call-backs Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 30/33] iommu/exynos: Use first SYSMMU in controllers list for IOMMU core Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 31/33] iommu/exynos: Convert to probe/release_device() call-backs Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 32/33] iommu: Remove add_device()/remove_device() code-paths Joerg Roedel
2020-04-14 13:15 ` [PATCH v2 33/33] iommu: Unexport iommu_group_get_for_dev() Joerg Roedel
2020-04-16 11:48 ` [PATCH v2 00/33] iommu: Move iommu_group setup to IOMMU core code Marek Szyprowski
2020-04-17 1:03 ` Daniel Drake [this message]
2020-04-17 1:14 ` Derrick, Jonathan
2020-04-18 12:44 ` joro
2020-05-29 22:16 ` Jerry Snitselaar
2020-06-01 10:42 ` Jerry Snitselaar
2020-06-01 13:17 ` Jerry Snitselaar
2020-06-01 23:20 ` Lu Baolu
2020-06-01 23:16 ` Lu Baolu
2020-06-02 0:02 ` Jerry Snitselaar
2020-06-02 14:23 ` Joerg Roedel
2020-06-02 16:38 ` Jerry Snitselaar
2020-06-02 21:17 ` Jerry Snitselaar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417010335.31739-1-drake@endlessm.com \
--to=drake@endlessm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jonathan.derrick@intel.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).