Hi Jacob, I love your patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on linux/master linus/master v5.9-rc1 next-20200821] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jacob-Pan/IOASID-extensions-for-guest-SVA/20200822-123111 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: mips-randconfig-r015-20200822 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b587ca93be114d07ec3bf654add97d7872325281) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from drivers/of/device.c:7: In file included from include/linux/of_iommu.h:6: In file included from include/linux/iommu.h:16: >> include/linux/ioasid.h:141:1: error: unknown type name 'staic'; did you mean 'static'? staic inline int ioasid_attach_spid(ioasid_t ioasid, ioasid_t spid) ^~~~~ static In file included from drivers/of/device.c:8: include/linux/dma-mapping.h:824:9: warning: implicit conversion from 'unsigned long long' to 'unsigned long' changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] return DMA_BIT_MASK(32); ~~~~~~ ^~~~~~~~~~~~~~~~ include/linux/dma-mapping.h:139:40: note: expanded from macro 'DMA_BIT_MASK' #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) ^~~~~ 1 warning and 1 error generated. -- In file included from drivers/of/platform.c:20: In file included from include/linux/of_iommu.h:6: In file included from include/linux/iommu.h:16: >> include/linux/ioasid.h:141:1: error: unknown type name 'staic'; did you mean 'static'? staic inline int ioasid_attach_spid(ioasid_t ioasid, ioasid_t spid) ^~~~~ static 1 error generated. # https://github.com/0day-ci/linux/commit/09f31e901946399a274ce954bdefa4108e895b33 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jacob-Pan/IOASID-extensions-for-guest-SVA/20200822-123111 git checkout 09f31e901946399a274ce954bdefa4108e895b33 vim +141 include/linux/ioasid.h 140 > 141 staic inline int ioasid_attach_spid(ioasid_t ioasid, ioasid_t spid) 142 { 143 return -ENOTSUPP; 144 } 145 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org