From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
jeremy.linton@arm.com, Sumit Semwal <sumit.semwal@linaro.org>,
iommu@lists.linux-foundation.org,
John Stultz <john.stultz@linaro.org>,
linux-rpi-kernel@lists.infradead.org,
David Rientjes <rientjes@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA
Date: Tue, 21 Jul 2020 10:39:49 +0200 [thread overview]
Message-ID: <550b30a86c0785049d24c945e2c6628d491cee3a.camel@suse.de> (raw)
In-Reply-To: <CAMi1Hd35tRM=cnmzwX=SDgu-OoXi1Xj+twFkoULaVZBbTpe6sw@mail.gmail.com>
Hi Amit,
On Tue, 2020-07-21 at 12:51 +0530, Amit Pundir wrote:
> On Wed, 8 Jul 2020 at 22:43, Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> > There is no guarantee to CMA's placement, so allocating a zone
> > specific
> > atomic pool from CMA might return memory from a completely
> > different
> > memory zone. So stop using it.
> >
> > Fixes: c84dc6e68a1d ("dma-pool: add additional coherent pools to
> > map to gfp mask")
>
> Hi Nicolas,
>
> I see a boot regression with this commit d9765e41d8e9 "dma-pool:
> Do not allocate pool memory from CMA" on my Xiaomi Poco F1
> (Qcom sdm845) phone running v5.8-rc6. I can't boot past the
> bootloader splash screen with this patch.
>
> Phone boots fine if I revert this patch. I carry only one out of tree
> dts patch https://lkml.org/lkml/2020/6/25/52. And since this is a
> stock
> phone, I don't have access to serial/dmesg logs until I boot to AOSP
> (adb) shell.
>
> Any thoughts as to what might be going wrong here? I'd be happy to
> help debug things. For what it's worth, I don't see this regression
> on
> other two sdm845 devices (db845c and Pixel 3) I tested on.
Can you provide a boot log (even if without my patch) and the device-
tree files? It'd help a lot figuring things out.
Regards,
Nicolas
> Regards,
> Amit Pundir
>
> > Reported-by: Jeremy Linton <jeremy.linton@arm.com>
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > ---
> >
> > An more costly alternative would be adding an option to
> > dma_alloc_from_contiguous() so it fails when the allocation doesn't
> > fall
> > in a specific zone.
> >
> > kernel/dma/pool.c | 11 ++---------
> > 1 file changed, 2 insertions(+), 9 deletions(-)
> >
> > diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c
> > index 8cfa01243ed2..4bc1c46ae6ef 100644
> > --- a/kernel/dma/pool.c
> > +++ b/kernel/dma/pool.c
> > @@ -6,7 +6,6 @@
> > #include <linux/debugfs.h>
> > #include <linux/dma-direct.h>
> > #include <linux/dma-noncoherent.h>
> > -#include <linux/dma-contiguous.h>
> > #include <linux/init.h>
> > #include <linux/genalloc.h>
> > #include <linux/set_memory.h>
> > @@ -69,12 +68,7 @@ static int atomic_pool_expand(struct gen_pool
> > *pool, size_t pool_size,
> >
> > do {
> > pool_size = 1 << (PAGE_SHIFT + order);
> > -
> > - if (dev_get_cma_area(NULL))
> > - page = dma_alloc_from_contiguous(NULL, 1 <<
> > order,
> > - order,
> > false);
> > - else
> > - page = alloc_pages(gfp, order);
> > + page = alloc_pages(gfp, order);
> > } while (!page && order-- > 0);
> > if (!page)
> > goto out;
> > @@ -118,8 +112,7 @@ static int atomic_pool_expand(struct gen_pool
> > *pool, size_t pool_size,
> > dma_common_free_remap(addr, pool_size);
> > #endif
> > free_page: __maybe_unused
> > - if (!dma_release_from_contiguous(NULL, page, 1 << order))
> > - __free_pages(page, order);
> > + __free_pages(page, order);
> > out:
> > return ret;
> > }
> > --
> > 2.27.0
> >
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-21 8:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 16:49 [PATCH] dma-pool: Do not allocate pool memory from CMA Nicolas Saenz Julienne
2020-07-08 16:58 ` Christoph Hellwig
2020-07-08 23:14 ` Jeremy Linton
2020-07-09 21:47 ` David Rientjes via iommu
2020-07-21 7:21 ` Amit Pundir
2020-07-21 8:39 ` Nicolas Saenz Julienne [this message]
2020-07-21 8:54 ` Amit Pundir
2020-07-21 11:15 ` Nicolas Saenz Julienne
2020-07-21 11:28 ` Christoph Hellwig
2020-07-21 11:37 ` Nicolas Saenz Julienne
2020-07-21 12:16 ` Amit Pundir
2020-07-21 12:15 ` Amit Pundir
2020-07-21 12:45 ` Nicolas Saenz Julienne
2020-07-21 15:22 ` Amit Pundir
2020-07-21 16:27 ` Nicolas Saenz Julienne
2020-07-23 5:14 ` Amit Pundir
2020-07-24 9:36 ` Nicolas Saenz Julienne
2020-07-24 11:06 ` Amit Pundir
2020-07-24 13:41 ` Christoph Hellwig
2020-07-24 16:19 ` Amit Pundir
2020-07-24 16:27 ` Christoph Hellwig
2020-07-27 17:56 ` Nicolas Saenz Julienne
2020-07-28 9:13 ` Christoph Hellwig
2020-07-28 9:30 ` Nicolas Saenz Julienne
2020-07-28 10:09 ` Christoph Hellwig
2020-07-31 1:10 ` Nathan Chancellor
2020-07-31 7:19 ` Amit Pundir
2020-07-31 10:09 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550b30a86c0785049d24c945e2c6628d491cee3a.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=amit.pundir@linaro.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jeremy.linton@arm.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).