From: Robin Murphy <robin.murphy@arm.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, joro@8bytes.org, will@kernel.org
Cc: linux-kernel@vger.kernel.org, dianders@chromium.org,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 18/23] iommu: Express DMA strictness via the domain type
Date: Mon, 26 Jul 2021 09:27:01 +0100 [thread overview]
Message-ID: <77057c4b-479b-c5b8-4666-f16e294552d1@arm.com> (raw)
In-Reply-To: <f5e902ce-54a2-af7b-b42e-f61f7f96c68e@linux.intel.com>
On 2021-07-24 06:29, Lu Baolu wrote:
> Hi Robin,
>
> On 2021/7/22 2:20, Robin Murphy wrote:
>> Eliminate the iommu_get_dma_strict() indirection and pipe the
>> information through the domain type from the beginning. Besides
>> the flow simplification this also has several nice side-effects:
>>
>> - Automatically implies strict mode for untrusted devices by
>> virtue of their IOMMU_DOMAIN_DMA override.
>> - Ensures that we only ends up using flush queues for drivers
>> which are aware of them and can actually benefit.
>
> Is this expressed by vendor iommu driver has ops->flush_iotlb_all?
No, it's literally whether ->domain_alloc accepts the DMA_DOMAIN_FQ type
or not.
>> - Allows us to handle flush queue init failure by falling back
>> to strict mode instead of leaving it to possibly blow up later.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
>> drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
>> drivers/iommu/dma-iommu.c | 10 ++++++----
>> drivers/iommu/iommu.c | 14 ++++----------
>> include/linux/iommu.h | 1 -
>> 5 files changed, 12 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>> b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>> index fa41026d272e..260b560d0075 100644
>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
>> @@ -2175,7 +2175,7 @@ static int arm_smmu_domain_finalise(struct
>> iommu_domain *domain,
>> .iommu_dev = smmu->dev,
>> };
>> - if (!iommu_get_dma_strict(domain))
>> + if (domain->type == IOMMU_DOMAIN_DMA_FQ)
>> pgtbl_cfg.quirks |= IO_PGTABLE_QUIRK_NON_STRICT;
>> pgtbl_ops = alloc_io_pgtable_ops(fmt, &pgtbl_cfg, smmu_domain);
>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> b/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> index dbc14c265b15..2c717f3be056 100644
>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
>> @@ -765,7 +765,7 @@ static int arm_smmu_init_domain_context(struct
>> iommu_domain *domain,
>> .iommu_dev = smmu->dev,
>> };
>> - if (!iommu_get_dma_strict(domain))
>> + if (domain->type == IOMMU_DOMAIN_DMA_FQ)
>> pgtbl_cfg.quirks |= IO_PGTABLE_QUIRK_NON_STRICT;
>> if (smmu->impl && smmu->impl->init_context) {
>> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
>> index b1af1ff324c5..a114a7ad88ec 100644
>> --- a/drivers/iommu/dma-iommu.c
>> +++ b/drivers/iommu/dma-iommu.c
>> @@ -363,13 +363,15 @@ static int iommu_dma_init_domain(struct
>> iommu_domain *domain, dma_addr_t base,
>> init_iova_domain(iovad, 1UL << order, base_pfn);
>> - if (!cookie->fq_domain && !dev_is_untrusted(dev) &&
>> - domain->ops->flush_iotlb_all && !iommu_get_dma_strict(domain)) {
>> + if (domain->type == IOMMU_DOMAIN_DMA_FQ && !cookie->fq_domain &&
>> + domain->ops->flush_iotlb_all) {
>> if (init_iova_flush_queue(iovad, iommu_dma_flush_iotlb_all,
>> - iommu_dma_entry_dtor))
>> + iommu_dma_entry_dtor)) {
>> pr_warn("iova flush queue initialization failed\n");
>> - else
>> + domain->type = IOMMU_DOMAIN_DMA;
>> + } else {
>> cookie->fq_domain = domain;
>> + }
>> }
>> return iova_reserve_iommu_regions(dev, domain);
>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>> index 8333c334891e..d7eaacae0944 100644
>> --- a/drivers/iommu/iommu.c
>> +++ b/drivers/iommu/iommu.c
>> @@ -135,6 +135,9 @@ static int __init iommu_subsys_init(void)
>> }
>> }
>> + if (!iommu_default_passthrough() && !iommu_dma_strict)
>> + iommu_def_domain_type = IOMMU_DOMAIN_DMA_FQ;
>> +
>> pr_info("Default domain type: %s %s\n",
>> iommu_domain_type_str(iommu_def_domain_type),
>> (iommu_cmd_line & IOMMU_CMD_LINE_DMA_API) ?
>> @@ -352,15 +355,6 @@ void iommu_set_dma_strict(bool strict)
>> iommu_dma_strict = strict;
>> }
>> -bool iommu_get_dma_strict(struct iommu_domain *domain)
>> -{
>> - /* only allow lazy flushing for DMA domains */
>> - if (domain->type == IOMMU_DOMAIN_DMA)
>> - return iommu_dma_strict;
>> - return true;
>> -}
>> -EXPORT_SYMBOL_GPL(iommu_get_dma_strict);
>> -
>> static ssize_t iommu_group_attr_show(struct kobject *kobj,
>> struct attribute *__attr, char *buf)
>> {
>> @@ -764,7 +758,7 @@ static int
>> iommu_create_device_direct_mappings(struct iommu_group *group,
>> unsigned long pg_size;
>> int ret = 0;
>> - if (!domain || domain->type != IOMMU_DOMAIN_DMA)
>> + if (!domain || !(domain->type & __IOMMU_DOMAIN_DMA_API))
>
> Nit: probably move above change to patch 14?
Indeed I'm not sure why this one ended up here, good catch!
Thanks,
Robin.
>> return 0;
>> BUG_ON(!domain->pgsize_bitmap);
>> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
>> index 56519110d43f..557c4c12e2cf 100644
>> --- a/include/linux/iommu.h
>> +++ b/include/linux/iommu.h
>> @@ -484,7 +484,6 @@ int iommu_set_pgtable_quirks(struct iommu_domain
>> *domain,
>> unsigned long quirks);
>> void iommu_set_dma_strict(bool val);
>> -bool iommu_get_dma_strict(struct iommu_domain *domain);
>> extern int report_iommu_fault(struct iommu_domain *domain, struct
>> device *dev,
>> unsigned long iova, int flags);
>>
>
> Best regards,
> baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-07-26 8:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 18:20 [PATCH 00/23] iommu: Refactor DMA domain strictness Robin Murphy
2021-07-21 18:20 ` [PATCH 01/23] iommu: Pull IOVA cookie management into the core Robin Murphy
2021-07-21 18:20 ` [PATCH 02/23] iommu/amd: Drop IOVA cookie management Robin Murphy
2021-07-21 18:20 ` [PATCH 03/23] iommu/arm-smmu: " Robin Murphy
2021-07-21 18:20 ` [PATCH 04/23] iommu/vt-d: " Robin Murphy
2021-07-21 18:20 ` [PATCH 05/23] iommu/exynos: " Robin Murphy
2021-07-21 18:20 ` [PATCH 06/23] iommu/ipmmu-vmsa: " Robin Murphy
2021-07-21 18:20 ` [PATCH 07/23] iommu/mtk: " Robin Murphy
2021-07-21 18:20 ` [PATCH 08/23] iommu/rockchip: " Robin Murphy
2021-07-21 18:20 ` [PATCH 09/23] iommu/sprd: " Robin Murphy
2021-07-21 18:20 ` [PATCH 10/23] iommu/sun50i: " Robin Murphy
2021-07-21 18:20 ` [PATCH 11/23] iommu/virtio: " Robin Murphy
2021-07-21 18:20 ` [PATCH 12/23] iommu/dma: Unexport " Robin Murphy
2021-07-21 18:20 ` [PATCH 13/23] iommu/dma: Remove redundant "!dev" checks Robin Murphy
2021-07-26 8:28 ` John Garry
2021-07-21 18:20 ` [PATCH 14/23] iommu: Introduce explicit type for non-strict DMA domains Robin Murphy
2021-07-21 18:20 ` [PATCH 15/23] iommu/amd: Prepare for multiple DMA domain types Robin Murphy
2021-07-21 18:20 ` [PATCH 16/23] iommu/arm-smmu: " Robin Murphy
2021-07-26 12:46 ` Joerg Roedel
2021-07-26 13:09 ` Robin Murphy
2021-07-26 18:43 ` Joerg Roedel
2021-07-21 18:20 ` [PATCH 17/23] iommu/vt-d: " Robin Murphy
2021-07-22 16:44 ` kernel test robot
2021-07-22 17:30 ` Robin Murphy
2021-07-22 18:44 ` kernel test robot
2021-07-24 5:23 ` Lu Baolu
2021-07-26 8:30 ` Robin Murphy
2021-07-21 18:20 ` [PATCH 18/23] iommu: Express DMA strictness via the domain type Robin Murphy
2021-07-24 5:29 ` Lu Baolu
2021-07-26 8:27 ` Robin Murphy [this message]
2021-07-26 11:31 ` Lu Baolu
2021-07-26 12:29 ` Lu Baolu
2021-07-26 12:43 ` Robin Murphy
2021-07-21 18:20 ` [PATCH 19/23] iommu: Expose DMA domain strictness via sysfs Robin Murphy
2021-07-21 18:20 ` [PATCH 20/23] iommu: Allow choosing DMA strictness at build time Robin Murphy
2021-07-21 18:20 ` [PATCH 21/23] iommu/dma: Factor out flush queue init Robin Murphy
2021-07-21 18:20 ` [PATCH 22/23] iommu: Allow enabling non-strict mode dynamically Robin Murphy
2021-07-21 18:20 ` [PATCH 23/23] iommu/arm-smmu: Allow non-strict in pgtable_quirks interface Robin Murphy
2021-07-26 8:13 ` [PATCH 00/23] iommu: Refactor DMA domain strictness John Garry
2021-07-26 12:06 ` Robin Murphy
2021-07-26 13:02 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77057c4b-479b-c5b8-4666-f16e294552d1@arm.com \
--to=robin.murphy@arm.com \
--cc=baolu.lu@linux.intel.com \
--cc=dianders@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).