From: Lu Baolu <baolu.lu@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: alan.cox@intel.com, Christoph Hellwig <hch@lst.de>,
Stefano Stabellini <sstabellini@kernel.org>,
ashok.raj@intel.com, Jonathan Corbet <corbet@lwn.net>,
pengfei.xu@intel.com, Ingo Molnar <mingo@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
kevin.tian@intel.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
mika.westerberg@linux.intel.com, Juergen Gross <jgross@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
jacob.jun.pan@intel.com, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v5 09/10] iommu/vt-d: Add trace events for device dma map/unmap
Date: Fri, 26 Jul 2019 10:24:52 +0800 [thread overview]
Message-ID: <8660ebce-59af-d920-b2c8-9ce721f896e7@linux.intel.com> (raw)
In-Reply-To: <20190725082621.2878936a@gandalf.local.home>
Hi,
On 7/25/19 8:26 PM, Steven Rostedt wrote:
> On Thu, 25 Jul 2019 11:17:16 +0800
> Lu Baolu <baolu.lu@linux.intel.com> wrote:
>
>> This adds trace support for the Intel IOMMU driver. It
>> also declares some events which could be used to trace
>> the events when an IOVA is being mapped or unmapped in
>> a domain.
>>
>> Cc: Ashok Raj <ashok.raj@intel.com>
>> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
>> Cc: Kevin Tian <kevin.tian@intel.com>
>> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> ---
>> drivers/iommu/Makefile | 1 +
>> drivers/iommu/intel-trace.c | 14 +++++
>> include/trace/events/intel_iommu.h | 95 ++++++++++++++++++++++++++++++
>> 3 files changed, 110 insertions(+)
>> create mode 100644 drivers/iommu/intel-trace.c
>> create mode 100644 include/trace/events/intel_iommu.h
>
> This patch looks fine, but I don't see the use cases for anything but
> trace_bounce_map_single() and trace_bounce_unmap_single() used.
This only adds trace event/point for this case. We will add more later.
>
> Other than that.
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Thank you!
Best regards,
Baolu
>
> -- Steve
>
>>
>> diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
>> index f13f36ae1af6..bfe27b2755bd 100644
>> --- a/drivers/iommu/Makefile
>> +++ b/drivers/iommu/Makefile
>> @@ -17,6 +17,7 @@ obj-$(CONFIG_ARM_SMMU) += arm-smmu.o
>> obj-$(CONFIG_ARM_SMMU_V3) += arm-smmu-v3.o
>> obj-$(CONFIG_DMAR_TABLE) += dmar.o
>> obj-$(CONFIG_INTEL_IOMMU) += intel-iommu.o intel-pasid.o
>> +obj-$(CONFIG_INTEL_IOMMU) += intel-trace.o
>> obj-$(CONFIG_INTEL_IOMMU_DEBUGFS) += intel-iommu-debugfs.o
>> obj-$(CONFIG_INTEL_IOMMU_SVM) += intel-svm.o
>> obj-$(CONFIG_IPMMU_VMSA) += ipmmu-vmsa.o
>> diff --git a/drivers/iommu/intel-trace.c b/drivers/iommu/intel-trace.c
>> new file mode 100644
>> index 000000000000..bfb6a6e37a88
>> --- /dev/null
>> +++ b/drivers/iommu/intel-trace.c
>> @@ -0,0 +1,14 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Intel IOMMU trace support
>> + *
>> + * Copyright (C) 2019 Intel Corporation
>> + *
>> + * Author: Lu Baolu <baolu.lu@linux.intel.com>
>> + */
>> +
>> +#include <linux/string.h>
>> +#include <linux/types.h>
>> +
>> +#define CREATE_TRACE_POINTS
>> +#include <trace/events/intel_iommu.h>
>> diff --git a/include/trace/events/intel_iommu.h b/include/trace/events/intel_iommu.h
>> new file mode 100644
>> index 000000000000..3fdeaad93b2e
>> --- /dev/null
>> +++ b/include/trace/events/intel_iommu.h
>> @@ -0,0 +1,95 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Intel IOMMU trace support
>> + *
>> + * Copyright (C) 2019 Intel Corporation
>> + *
>> + * Author: Lu Baolu <baolu.lu@linux.intel.com>
>> + */
>> +#ifdef CONFIG_INTEL_IOMMU
>> +#undef TRACE_SYSTEM
>> +#define TRACE_SYSTEM intel_iommu
>> +
>> +#if !defined(_TRACE_INTEL_IOMMU_H) || defined(TRACE_HEADER_MULTI_READ)
>> +#define _TRACE_INTEL_IOMMU_H
>> +
>> +#include <linux/tracepoint.h>
>> +#include <linux/intel-iommu.h>
>> +
>> +DECLARE_EVENT_CLASS(dma_map,
>> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr,
>> + size_t size),
>> +
>> + TP_ARGS(dev, dev_addr, phys_addr, size),
>> +
>> + TP_STRUCT__entry(
>> + __string(dev_name, dev_name(dev))
>> + __field(dma_addr_t, dev_addr)
>> + __field(phys_addr_t, phys_addr)
>> + __field(size_t, size)
>> + ),
>> +
>> + TP_fast_assign(
>> + __assign_str(dev_name, dev_name(dev));
>> + __entry->dev_addr = dev_addr;
>> + __entry->phys_addr = phys_addr;
>> + __entry->size = size;
>> + ),
>> +
>> + TP_printk("dev=%s dev_addr=0x%llx phys_addr=0x%llx size=%zu",
>> + __get_str(dev_name),
>> + (unsigned long long)__entry->dev_addr,
>> + (unsigned long long)__entry->phys_addr,
>> + __entry->size)
>> +);
>> +
>> +DEFINE_EVENT(dma_map, bounce_map_single,
>> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr,
>> + size_t size),
>> + TP_ARGS(dev, dev_addr, phys_addr, size)
>> +);
>> +
>> +DEFINE_EVENT(dma_map, bounce_map_sg,
>> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr,
>> + size_t size),
>> + TP_ARGS(dev, dev_addr, phys_addr, size)
>> +);
>> +
>> +DECLARE_EVENT_CLASS(dma_unmap,
>> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size),
>> +
>> + TP_ARGS(dev, dev_addr, size),
>> +
>> + TP_STRUCT__entry(
>> + __string(dev_name, dev_name(dev))
>> + __field(dma_addr_t, dev_addr)
>> + __field(size_t, size)
>> + ),
>> +
>> + TP_fast_assign(
>> + __assign_str(dev_name, dev_name(dev));
>> + __entry->dev_addr = dev_addr;
>> + __entry->size = size;
>> + ),
>> +
>> + TP_printk("dev=%s dev_addr=0x%llx size=%zu",
>> + __get_str(dev_name),
>> + (unsigned long long)__entry->dev_addr,
>> + __entry->size)
>> +);
>> +
>> +DEFINE_EVENT(dma_unmap, bounce_unmap_single,
>> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size),
>> + TP_ARGS(dev, dev_addr, size)
>> +);
>> +
>> +DEFINE_EVENT(dma_unmap, bounce_unmap_sg,
>> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size),
>> + TP_ARGS(dev, dev_addr, size)
>> +);
>> +
>> +#endif /* _TRACE_INTEL_IOMMU_H */
>> +
>> +/* This part must be outside protection */
>> +#include <trace/define_trace.h>
>> +#endif /* CONFIG_INTEL_IOMMU */
>
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-07-26 2:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 3:17 [PATCH v5 00/10] iommu: Bounce page for untrusted devices Lu Baolu
2019-07-25 3:17 ` [PATCH v5 01/10] iommu/vt-d: Don't switch off swiotlb if use direct dma Lu Baolu
2019-07-25 5:41 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 02/10] iommu/vt-d: Use per-device dma_ops Lu Baolu
2019-07-25 5:44 ` Christoph Hellwig
2019-07-25 7:18 ` Lu Baolu
2019-07-25 11:43 ` Christoph Hellwig
2019-07-26 1:56 ` Lu Baolu
2019-11-12 7:16 ` Christoph Hellwig
2019-11-13 2:50 ` Lu Baolu
2019-11-13 7:03 ` Christoph Hellwig
2019-11-13 9:53 ` Christoph Hellwig
2019-11-14 5:14 ` Lu Baolu
2019-11-14 8:14 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 03/10] iommu/vt-d: Cleanup after use per-device dma ops Lu Baolu
2019-07-25 3:17 ` [PATCH v5 04/10] PCI: Add dev_is_untrusted helper Lu Baolu
2019-07-25 5:44 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 05/10] swiotlb: Split size parameter to map/unmap APIs Lu Baolu
2019-07-25 11:47 ` Christoph Hellwig
2019-07-25 3:17 ` [PATCH v5 06/10] swiotlb: Zero out bounce buffer for untrusted device Lu Baolu
2019-07-25 11:49 ` Christoph Hellwig
2019-07-26 2:21 ` Lu Baolu
2019-07-25 3:17 ` [PATCH v5 07/10] iommu: Add bounce page APIs Lu Baolu
2019-07-25 3:17 ` [PATCH v5 08/10] iommu/vt-d: Check whether device requires bounce buffer Lu Baolu
2019-07-25 3:17 ` [PATCH v5 09/10] iommu/vt-d: Add trace events for device dma map/unmap Lu Baolu
2019-07-25 12:26 ` Steven Rostedt
2019-07-26 2:24 ` Lu Baolu [this message]
2019-07-25 3:17 ` [PATCH v5 10/10] iommu/vt-d: Use bounce buffer for untrusted devices Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8660ebce-59af-d920-b2c8-9ce721f896e7@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alan.cox@intel.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgross@suse.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=pengfei.xu@intel.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).