From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C61DC4727E for ; Sat, 26 Sep 2020 15:25:50 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1D1A20878 for ; Sat, 26 Sep 2020 15:25:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IgNtiCGT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1D1A20878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 990A987251; Sat, 26 Sep 2020 15:25:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QSKu63YLRJcC; Sat, 26 Sep 2020 15:25:48 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id C98AB8724F; Sat, 26 Sep 2020 15:25:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A953EC0891; Sat, 26 Sep 2020 15:25:48 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1EC0CC0859 for ; Sat, 26 Sep 2020 15:25:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0711685F8F for ; Sat, 26 Sep 2020 15:25:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CM2Lio8pTkxK for ; Sat, 26 Sep 2020 15:25:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 0420185F8C for ; Sat, 26 Sep 2020 15:25:46 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id g4so5556366edk.0 for ; Sat, 26 Sep 2020 08:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NyijGOIcOg0IQ8xJ7tRK9WXb8VbwFr7joS3ngRxTFtY=; b=IgNtiCGTIRw+9Jq9+OugAEUgOtWjA8eNb9N0lGKIZhSzq8+Nq6i8p6dAPgDSw3WCu5 5zLCQcy1nGd484dN8MEuuVSYHqucVtHjEfU81Ws4/lYX/HOp4JbMrZzXbrOql6BtdQAy +hEnD/Pr6tT/viPh9YkxxEEc7eplb0NwJB92c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NyijGOIcOg0IQ8xJ7tRK9WXb8VbwFr7joS3ngRxTFtY=; b=LC5LwC8ONd2HQl/lZFjdUJPvG923+wA6cjyNbO2ERKjWJV7egKcv7ec42k/6IJrqAJ FBMPpWXrW6bzX97CQIxUIPJHXSwr0R4YPetD2840KviTG1RT0aLnWybGjubtmsJC0oMM trXeg7OoF5Nwjtrcoa173iQKE/MOZprx92X65mRqnHeUdRzNgbljEb06JaERsDsdweXt TVY+7dFtzzMDKG5wGIRKlX7Ff8GUJoIt8X9eFg7ytm0NoQcCpO/rDxLc2O/qHoYp+H7P ezfrYggd1inkpmdgf0GpvZKfwPEJ6Nj2PWSJMcvJnY1btli86QdaBEJKutKS7F1sUti7 qvQw== X-Gm-Message-State: AOAM531tvKab76koY8FB/HSdlYUmELNOAAe53UUAzgYOEGXMtBi4JOuu 9iL2xhhU6giE6tILJ6ps1fz+mC4aj4mZpg== X-Google-Smtp-Source: ABdhPJzt0ckBReRcqedW9M8wBlxL9gs844WQ55D5niv6WBRoA95615f7vbbU1ldyqqdDAHebV0LEUw== X-Received: by 2002:a05:6402:144c:: with SMTP id d12mr7238469edx.168.1601133944367; Sat, 26 Sep 2020 08:25:44 -0700 (PDT) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id u15sm4566536edq.96.2020.09.26.08.25.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Sep 2020 08:25:44 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id k18so2321254wmj.5 for ; Sat, 26 Sep 2020 08:25:43 -0700 (PDT) X-Received: by 2002:a7b:c925:: with SMTP id h5mr2968012wml.28.1601133943201; Sat, 26 Sep 2020 08:25:43 -0700 (PDT) MIME-Version: 1.0 References: <20200915155122.1768241-1-hch@lst.de> <20200915155122.1768241-18-hch@lst.de> <20200925184622.GB3607091@chromium.org> <20200926141428.GB10379@lst.de> In-Reply-To: <20200926141428.GB10379@lst.de> From: Tomasz Figa Date: Sat, 26 Sep 2020 17:25:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 17/18] dma-iommu: implement ->alloc_noncoherent To: Christoph Hellwig Cc: alsa-devel@alsa-project.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, linux1394-devel@lists.sourceforge.net, linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Ben Skeggs , Matt Porter , Linux Media Mailing List , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Stefan Richter X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Sat, Sep 26, 2020 at 4:14 PM Christoph Hellwig wrote: > > On Fri, Sep 25, 2020 at 06:46:22PM +0000, Tomasz Figa wrote: > > > +static void *iommu_dma_alloc_noncoherent(struct device *dev, size_t size, > > > + dma_addr_t *handle, enum dma_data_direction dir, gfp_t gfp) > > > +{ > > > + if (!gfpflags_allow_blocking(gfp)) { > > > + struct page *page; > > > + > > > + page = dma_common_alloc_pages(dev, size, handle, dir, gfp); > > > + if (!page) > > > + return NULL; > > > + return page_address(page); > > > + } > > > + > > > + return iommu_dma_alloc_remap(dev, size, handle, gfp | __GFP_ZERO, > > > + PAGE_KERNEL, 0); > > > > iommu_dma_alloc_remap() makes use of the DMA_ATTR_ALLOC_SINGLE_PAGES attribute > > to optimize the allocations for devices which don't care about how contiguous > > the backing memory is. Do you think we could add an attrs argument to this > > function and pass it there? > > > > As ARM is being moved to the common iommu-dma layer as well, we'll probably > > make use of the argument to support the DMA_ATTR_NO_KERNEL_MAPPING attribute to > > conserve the vmalloc area. > > We could probably at it. However I wonder why this is something the > drivers should care about. Isn't this really something that should > be a kernel-wide policy for a given system? There are IOMMUs out there which support huge pages and those can benefit *some* hardware depending on what kind of accesses they perform, possibly on a per-buffer basis. At the same time, order > 0 allocations can be expensive, significantly affecting allocation latency, so for devices which don't care about huge pages anyone would prefer simple single-page allocations. Currently the drivers know the best on whether the hardware they drive would care. There are some decision factors listed in the documentation [1]. I can imagine cases where drivers could not be the best to decide about this - for example, the workload could vary depending on the userspace or a product decision regarding the performance vs allocation latency, but we haven't seen such cases in practice yet. [1] https://www.kernel.org/doc/html/latest/core-api/dma-attributes.html?highlight=dma_attr_alloc_single_pages#dma-attr-alloc-single-pages Best regards, Tomasz _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu