From: Ikjoon Jang <ikjn@chromium.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: youlin.pei@mediatek.com,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
yi.kuo@mediatek.com, srv_heupstream <srv_heupstream@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Robin Murphy <robin.murphy@arm.com>,
open list <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
anthony.huang@mediatek.com, ming-fan.chen@mediatek.com,
anan.sun@mediatek.com, Will Deacon <will@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 04/11] memory: mtk-smi: Rename smi_gen to smi_type
Date: Wed, 21 Jul 2021 18:44:13 +0800 [thread overview]
Message-ID: <CAATdQgB9eKCBvxV8R8jgkAa8Hqdbu4=nc9frMA024PvMnWWTaw@mail.gmail.com> (raw)
In-Reply-To: <20210715121209.31024-5-yong.wu@mediatek.com>
On Thu, Jul 15, 2021 at 8:14 PM Yong Wu <yong.wu@mediatek.com> wrote:
>
> Prepare for adding smi sub common. Only rename from smi_gen to smi_type.
> No functional change.
>
> About the current "smi_gen", we have gen1/gen2 that stand for the
> generation number for HW. I plan to add a new type(sub_common), then the
> name "gen" is not prober.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Ikjoon Jang <ikjn@chromium.org>
> ---
> drivers/memory/mtk-smi.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index a2213452059d..ff07b14bcd66 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -55,7 +55,7 @@
> /* All are MMU0 defaultly. Only specialize mmu1 here. */
> #define F_MMU1_LARB(larbid) (0x1 << SMI_BUS_LARB_SHIFT(larbid))
>
> -enum mtk_smi_gen {
> +enum mtk_smi_type {
> MTK_SMI_GEN1,
> MTK_SMI_GEN2
> };
> @@ -68,8 +68,8 @@ static const char * const mtk_smi_common_clks_optional[] = {"gals0", "gals1"};
> static const char * const mtk_smi_larb_clks_optional[] = {"gals"};
>
> struct mtk_smi_common_plat {
> - enum mtk_smi_gen gen;
> - u32 bus_sel; /* Balance some larbs to enter mmu0 or mmu1 */
> + enum mtk_smi_type type;
> + u32 bus_sel; /* Balance some larbs to enter mmu0 or mmu1 */
> };
>
> struct mtk_smi_larb_gen {
> @@ -402,27 +402,27 @@ static struct platform_driver mtk_smi_larb_driver = {
> };
>
> static const struct mtk_smi_common_plat mtk_smi_common_gen1 = {
> - .gen = MTK_SMI_GEN1,
> + .type = MTK_SMI_GEN1,
> };
>
> static const struct mtk_smi_common_plat mtk_smi_common_gen2 = {
> - .gen = MTK_SMI_GEN2,
> + .type = MTK_SMI_GEN2,
> };
>
> static const struct mtk_smi_common_plat mtk_smi_common_mt6779 = {
> - .gen = MTK_SMI_GEN2,
> - .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(4) |
> - F_MMU1_LARB(5) | F_MMU1_LARB(6) | F_MMU1_LARB(7),
> + .type = MTK_SMI_GEN2,
> + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(4) |
> + F_MMU1_LARB(5) | F_MMU1_LARB(6) | F_MMU1_LARB(7),
> };
>
> static const struct mtk_smi_common_plat mtk_smi_common_mt8183 = {
> - .gen = MTK_SMI_GEN2,
> + .type = MTK_SMI_GEN2,
> .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(5) |
> F_MMU1_LARB(7),
> };
>
> static const struct mtk_smi_common_plat mtk_smi_common_mt8192 = {
> - .gen = MTK_SMI_GEN2,
> + .type = MTK_SMI_GEN2,
> .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(5) |
> F_MMU1_LARB(6),
> };
> @@ -483,7 +483,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
> * clock into emi clock domain, but for mtk smi gen2, there's no smi ao
> * base.
> */
> - if (common->plat->gen == MTK_SMI_GEN1) {
> + if (common->plat->type == MTK_SMI_GEN1) {
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> common->smi_ao_base = devm_ioremap_resource(dev, res);
> if (IS_ERR(common->smi_ao_base))
> @@ -523,7 +523,7 @@ static int __maybe_unused mtk_smi_common_resume(struct device *dev)
> if (ret)
> return ret;
>
> - if (common->plat->gen == MTK_SMI_GEN2 && bus_sel)
> + if (common->plat->type == MTK_SMI_GEN2 && bus_sel)
> writel(bus_sel, common->base + SMI_BUS_SEL);
> return 0;
> }
> --
> 2.18.0
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-07-21 10:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 12:11 [PATCH v2 00/11] MT8195 SMI support Yong Wu
2021-07-15 12:11 ` [PATCH v2 01/11] dt-bindings: memory: mediatek: Add mt8195 smi binding Yong Wu
2021-07-22 2:51 ` Rob Herring
2021-07-15 12:12 ` [PATCH v2 02/11] dt-bindings: memory: mediatek: Add mt8195 smi sub common Yong Wu
2021-07-22 2:53 ` Rob Herring
2021-07-15 12:12 ` [PATCH v2 03/11] memory: mtk-smi: Use clk_bulk clock ops Yong Wu
2021-07-21 10:43 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 04/11] memory: mtk-smi: Rename smi_gen to smi_type Yong Wu
2021-07-21 10:44 ` Ikjoon Jang [this message]
2021-07-15 12:12 ` [PATCH v2 05/11] memory: mtk-smi: Adjust some code position Yong Wu
2021-07-21 10:44 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe Yong Wu
2021-07-21 10:45 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 07/11] memory: mtk-smi: Add smi sub common support Yong Wu
2021-07-21 11:43 ` Ikjoon Jang
2021-07-22 6:38 ` Yong Wu
2021-07-15 12:12 ` [PATCH v2 08/11] memory: mtk-smi: Use devm_platform_ioremap_resource Yong Wu
2021-07-21 11:44 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 09/11] memory: mtk-smi: mt8195: Add smi support Yong Wu
2021-07-21 12:39 ` Ikjoon Jang
2021-07-15 12:12 ` [PATCH v2 10/11] memory: mtk-smi: mt8195: Add initial setting for smi-common Yong Wu
2021-07-21 12:54 ` Ikjoon Jang
2021-07-22 6:38 ` Yong Wu
2021-07-15 12:12 ` [PATCH v2 11/11] memory: mtk-smi: mt8195: Add initial setting for smi-larb Yong Wu
2021-07-21 13:40 ` Ikjoon Jang
2021-07-22 6:38 ` Yong Wu
2021-07-29 6:41 ` Yong Wu
2021-08-03 5:37 ` Ikjoon Jang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATdQgB9eKCBvxV8R8jgkAa8Hqdbu4=nc9frMA024PvMnWWTaw@mail.gmail.com' \
--to=ikjn@chromium.org \
--cc=anan.sun@mediatek.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming-fan.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).