From: Amit Pundir <amit.pundir@linaro.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: jeremy.linton@arm.com, iommu@lists.linux-foundation.org,
linux-rpi-kernel@lists.infradead.org,
David Rientjes <rientjes@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: dma-pool fixes
Date: Sat, 1 Aug 2020 13:04:17 +0530 [thread overview]
Message-ID: <CAMi1Hd2q80DRLupke-ihywmX_3AX4HQ4PZNTuD=WxXe3AVM4gQ@mail.gmail.com> (raw)
In-Reply-To: <CAMi1Hd3Wc9tLRxgtX30AmGoSP6Go+p=17ezJhXFMxt+4Xn540A@mail.gmail.com>
On Fri, 31 Jul 2020 at 19:50, Amit Pundir <amit.pundir@linaro.org> wrote:
>
> On Fri, 31 Jul 2020 at 19:45, Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> >
> > On Fri, 2020-07-31 at 16:47 +0530, Amit Pundir wrote:
> > > On Fri, 31 Jul 2020 at 16:17, Nicolas Saenz Julienne
> >
> > [...]
> >
> > > > Ok, so lets see who's doing what and with what constraints:
> > >
> > > Here is the relevant dmesg log: https://pastebin.ubuntu.com/p/dh3pPnxS2v/
> >
> > Sadly nothing out of the ordinary, looks reasonable.
> >
> > I have an idea, I've been going over the downstream device tree and it seems
> > the reserved-memory entries, specially the ones marked with 'no-map' don't
> > fully match what we have upstream. On top of that all these reserved areas seem
> > to fall into ZONE_DMA.
> >
> > So, what could be happening is that, while allocating pages for the ZONE_DMA
> > atomic pool, something in the page allocator is either writing/mapping into a
> > reserved area triggering some kind of fault.
> >
> > Amir, could you go over the no-map reserved-memory entries in the downstream
> > device-tree, both in 'beryllium-*.dtsi' (I think those are the relevant ones)
> > and 'sdm845.dtsi'[1], and make sure they match what you are using. If not just
> > edit them in and see if it helps. If you need any help with that I'll be happy
> > to give you a hand.
>
> Thank you for the pointers. I'll try to match my dts' reserved-memory
> entries with the downstream dts. I'll let you know how it goes.
>
I matched my dts's reserved-memory nodes with downstream but it didn't help.
Most of the no-map reserved memory regions in the downstream kernel
are accompanied with "removed-dma-pool" compatibility, "to indicate a
region of memory which is meant to be carved out and not exposed to
kernel." [1][2]. Is this something which might be tripping my device
off? I tried to cherry-pick removed-dma-pool from msm kernel[3], to
see if that makes any difference but I might have missed a few
dependencies and my device didn't boot.
[1] https://android.googlesource.com/kernel/msm/+/e9171c1c69c31ec2226f0871fb5535b6f2044ef3%5E%21/#F0
[2] https://lore.kernel.org/patchwork/patch/670515/#857952
[3] https://github.com/OnePlusOSS/android_kernel_oneplus_sm8250/commit/a478a8bf78ade799a5626cee45c2b247071b325f
> Regards,
> Amit Pundir
>
> >
> > Regards,
> > Nicolas
> >
> > [1] You could also extract the device tree from a device running with the
> > downstream kernel, whatever is easier for you.
> >
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-08-01 7:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 10:47 dma-pool fixes Christoph Hellwig
2020-07-28 10:47 ` [PATCH 1/2] dma-pool: fix coherent pool allocations for IOMMU mappings Christoph Hellwig
2020-07-28 14:56 ` Nicolas Saenz Julienne
2020-07-28 15:28 ` Christoph Hellwig
2020-07-28 10:47 ` [PATCH 2/2] dma-pool: Only allocate from CMA when in same memory zone Christoph Hellwig
2020-07-28 12:02 ` dma-pool fixes Amit Pundir
2020-07-28 12:07 ` Christoph Hellwig
2020-07-28 12:25 ` Amit Pundir
2020-07-28 12:41 ` Christoph Hellwig
2020-07-28 12:48 ` Amit Pundir
2020-07-28 15:30 ` Christoph Hellwig
2020-07-29 10:45 ` Nicolas Saenz Julienne
2020-07-29 12:22 ` Amit Pundir
2020-07-31 7:46 ` Amit Pundir
2020-07-31 13:09 ` Christoph Hellwig
2020-07-31 14:15 ` Amit Pundir
2020-07-31 19:04 ` David Rientjes via iommu
2020-08-01 8:20 ` David Rientjes via iommu
2020-08-01 8:57 ` revert scope for 5.8, was " Christoph Hellwig
2020-08-01 11:57 ` Amit Pundir
2020-08-01 16:59 ` Nicolas Saenz Julienne
2020-08-01 17:39 ` Christoph Hellwig
2020-08-02 4:46 ` Amit Pundir
2020-08-02 15:04 ` Amit Pundir
2020-08-03 4:14 ` David Rientjes via iommu
2020-08-03 6:44 ` Christoph Hellwig
2020-08-03 18:30 ` David Rientjes via iommu
2020-08-01 18:28 ` Linus Torvalds
2020-08-02 4:35 ` Amit Pundir
2020-08-01 8:29 ` Christoph Hellwig
2020-07-31 10:47 ` Nicolas Saenz Julienne
2020-07-31 11:17 ` Amit Pundir
2020-07-31 14:15 ` Nicolas Saenz Julienne
2020-07-31 14:20 ` Amit Pundir
2020-08-01 7:34 ` Amit Pundir [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMi1Hd2q80DRLupke-ihywmX_3AX4HQ4PZNTuD=WxXe3AVM4gQ@mail.gmail.com' \
--to=amit.pundir@linaro.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jeremy.linton@arm.com \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).