iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: "Zeng, Jason" <jason.zeng@intel.com>,
	Deepa Dinamani <deepa.kernel@gmail.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH] intel-iommu: Turn off translations at shutdown
Date: Fri, 08 Nov 2019 08:57:11 +0000	[thread overview]
Message-ID: <addba4e401c3bf23b86cf8dff97256282895e29f.camel@infradead.org> (raw)
In-Reply-To: <8D8B600C3EC1B64FAD4503F0B66C61F23BB95B@SHSMSX103.ccr.corp.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1576 bytes --]

On Fri, 2019-11-08 at 08:47 +0000, Zeng, Jason wrote:
> > -----Original Message-----
> > From: David Woodhouse <dwmw2@infradead.org>
> > Sent: Friday, November 8, 2019 3:54 PM
> > To: Deepa Dinamani <deepa.kernel@gmail.com>; joro@8bytes.org; linux-
> > kernel@vger.kernel.org
> > Cc: iommu@lists.linux-foundation.org; Zeng, Jason <jason.zeng@intel.com>;
> > Tian, Kevin <kevin.tian@intel.com>
> > Subject: Re: [PATCH] intel-iommu: Turn off translations at shutdown
> > 
> > On Thu, 2019-11-07 at 12:59 -0800, Deepa Dinamani wrote:
> > > The intel-iommu driver assumes that the iommu state is
> > > cleaned up at the start of the new kernel.
> > > But, when we try to kexec boot something other than the
> > > Linux kernel, the cleanup cannot be relied upon.
> > > Hence, cleanup before we go down for reboot.
> > > 
> > > Keeping the cleanup at initialization also, in case BIOS
> > > leaves the IOMMU enabled.
> > > 
> > > I considered turning off iommu only during kexec reboot,
> > > but a clean shutdown seems always a good idea. But if
> > > someone wants to make it conditional, we can do that.
> > 
> > This is going to break things for the VMM live update scheme that Jason
> > presented at KVM Forum, isn't it?
> > 
> > In that case we rely on the IOMMU still operating during the
> > transition.
> 
> For VMM live update case, we should be able to detect and bypass
> the shutdown that Deepa introduced here, so keep IOMMU still operating?

Is that a 'yes' to Deepa's "if someone wants to make it conditional, we
can do that" ? 


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2019-11-08  8:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 20:59 [PATCH] intel-iommu: Turn off translations at shutdown Deepa Dinamani
2019-11-07 21:27 ` Deepa Dinamani
2019-11-08  3:07   ` Lu Baolu
2019-11-08  3:06 ` Lu Baolu
2019-11-08 22:28   ` Deepa Dinamani
2019-11-09  0:35     ` Lu Baolu
2019-11-08  7:54 ` David Woodhouse
2019-11-08  8:47   ` Zeng, Jason
2019-11-08  8:57     ` David Woodhouse [this message]
2019-11-08  9:11       ` Zeng, Jason
2019-11-08 22:48         ` Deepa Dinamani
2019-11-10 18:24           ` Deepa Dinamani
2019-11-10 20:36             ` Deepa Dinamani
2019-11-11  2:35               ` Zeng, Jason
2019-11-11  0:39           ` Zeng, Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=addba4e401c3bf23b86cf8dff97256282895e29f.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=deepa.kernel@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jason.zeng@intel.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).