From: John Garry <john.garry@huawei.com>
To: Will Deacon <will@kernel.org>, <iommu@lists.linux-foundation.org>,
"Robin Murphy" <robin.murphy@arm.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
Ming Lei <ming.lei@redhat.com>, Marc Zyngier <maz@kernel.org>
Subject: arm-smmu-v3 high cpu usage for NVMe
Date: Thu, 2 Jan 2020 17:44:39 +0000 [thread overview]
Message-ID: <b2a6e26d-6d0d-7f0d-f222-589812f701d2@huawei.com> (raw)
In-Reply-To: <20190821151749.23743-1-will@kernel.org>
Hi Will, Robin,
While analyzing an arm64 issue in interrupt handling for NVMe [0], we
have noticed a worryingly high CPU utilization in the SMMU driver.
The background is that we may get CPU lockup for high-throughput NVMe
testing, and we noticed that disabling the SMMU during testing avoids
the issue. However this lockup is a cross-architecture issue and there
are attempts to address it, like [1]. To me, disabling the SMMU is just
avoiding that specific issue.
Anyway, we should still consider this high CPU loading:
PerfTop: 1694 irqs/sec kernel:97.3% exact: 0.0% lost: 0/0
drop: 0/0 [4000Hz cycles], (all, CPU: 0)
--------------------------------------------------------------------------------------------------------------------------
50.84% [kernel] [k] arm_smmu_cmdq_issue_cmdlist
19.51% [kernel] [k] _raw_spin_unlock_irqrestore
5.14% [kernel] [k] __slab_free
2.37% [kernel] [k] bio_release_pages.part.42
2.20% [kernel] [k] fput_many
1.92% [kernel] [k] aio_complete_rw
1.85% [kernel] [k] __arm_lpae_unmap
1.71% [kernel] [k] arm_smmu_atc_inv_domain.constprop.42
1.11% [kernel] [k] sbitmap_queue_clear
1.05% [kernel] [k] blk_mq_free_request
0.97% [kernel] [k] nvme_irq
0.71% [kernel] [k] blk_account_io_done
0.66% [kernel] [k] kmem_cache_free
0.66% [kernel] [k] blk_mq_complete_request
This is for a CPU servicing the NVMe interrupt and doing the DMA unmap.
The DMA unmap is done in threaded interrupt context.
And for the overall system, we have:
PerfTop: 85864 irqs/sec kernel:89.6% exact: 0.0% lost: 0/34434
drop: 0/40116 [4000Hz cycles], (all, 96 CPUs)
--------------------------------------------------------------------------------------------------------------------------
27.43% [kernel] [k] arm_smmu_cmdq_issue_cmdlist
11.71% [kernel] [k] _raw_spin_unlock_irqrestore
6.35% [kernel] [k] _raw_spin_unlock_irq
2.65% [kernel] [k] get_user_pages_fast
2.03% [kernel] [k] __slab_free
1.55% [kernel] [k] tick_nohz_idle_exit
1.47% [kernel] [k] arm_lpae_map
1.39% [kernel] [k] __fget
1.14% [kernel] [k] __lock_text_start
1.09% [kernel] [k] _raw_spin_lock
1.08% [kernel] [k] bio_release_pages.part.42
1.03% [kernel] [k] __sbitmap_get_word
0.97% [kernel] [k] arm_smmu_atc_inv_domain.constprop.42
0.91% [kernel] [k] fput_many
0.88% [kernel] [k] __arm_lpae_map
One thing to note is that we still spend an appreciable amount of time
in arm_smmu_atc_inv_domain(), which is disappointing when considering it
should effectively be a noop.
As for arm_smmu_cmdq_issue_cmdlist(), I do note that during the testing
our batch size is 1, so we're not seeing the real benefit of the
batching. I can't help but think that we could improve this code to try
to combine CMD SYNCs for small batches.
Anyway, let me know your thoughts or any questions. I'll have a look if
a get a chance for other possible bottlenecks.
[0]
https://lore.kernel.org/lkml/e815b5451ea86e99d42045f7067f455a@www.loen.fr/
[1]
https://lore.kernel.org/linux-nvme/20191209175622.1964-1-kbusch@kernel.org/
Cheers,
John
On 21/08/2019 16:17, Will Deacon wrote:
> Hi again,
>
> This is version two of the patches I posted yesterday:
>
> v1: https://lkml.kernel.org/r/20190820154549.17018-1-will@kernel.org
>
> Changes since then include:
>
> * Fix 'ats_enabled' checking when enabling ATS
> * Remove redundant 'dev_is_pci()' calls
> * Remove bool bitfield
> * Add patch temporarily disabling ATS detection for -stable
> * Issue ATC invalidation even when non-leaf
> * Elide invalidation/SYNC for zero-sized address ranges
> * Shuffle the patches round a bit
>
> Thanks,
>
> Will
>
> Cc: Zhen Lei <thunder.leizhen@huawei.com>
> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
>
> --->8
>
> Will Deacon (8):
> iommu/arm-smmu-v3: Document ordering guarantees of command insertion
> iommu/arm-smmu-v3: Disable detection of ATS and PRI
> iommu/arm-smmu-v3: Remove boolean bitfield for 'ats_enabled' flag
> iommu/arm-smmu-v3: Don't issue CMD_SYNC for zero-length invalidations
> iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters
> iommu/arm-smmu-v3: Fix ATC invalidation ordering wrt main TLBs
> iommu/arm-smmu-v3: Avoid locking on invalidation path when not using
> ATS
> Revert "iommu/arm-smmu-v3: Disable detection of ATS and PRI"
>
> drivers/iommu/arm-smmu-v3.c | 117 ++++++++++++++++++++++++++++++++------------
> 1 file changed, 87 insertions(+), 30 deletions(-)
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-01-02 17:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:17 [PATCH v2 0/8] Sort out SMMUv3 ATC invalidation and locking Will Deacon
2019-08-21 15:17 ` [PATCH v2 1/8] iommu/arm-smmu-v3: Document ordering guarantees of command insertion Will Deacon
2019-08-21 15:17 ` [PATCH v2 2/8] iommu/arm-smmu-v3: Disable detection of ATS and PRI Will Deacon
2019-08-21 15:36 ` Robin Murphy
2019-08-21 15:17 ` [PATCH v2 3/8] iommu/arm-smmu-v3: Remove boolean bitfield for 'ats_enabled' flag Will Deacon
2019-08-21 15:17 ` [PATCH v2 4/8] iommu/arm-smmu-v3: Don't issue CMD_SYNC for zero-length invalidations Will Deacon
2019-08-21 15:17 ` [PATCH v2 5/8] iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters Will Deacon
2019-08-21 15:50 ` Robin Murphy
2019-08-21 15:17 ` [PATCH v2 6/8] iommu/arm-smmu-v3: Fix ATC invalidation ordering wrt main TLBs Will Deacon
2019-08-21 16:25 ` Robin Murphy
2019-08-21 15:17 ` [PATCH v2 7/8] iommu/arm-smmu-v3: Avoid locking on invalidation path when not using ATS Will Deacon
2019-08-22 12:36 ` Robin Murphy
2019-08-21 15:17 ` [PATCH v2 8/8] Revert "iommu/arm-smmu-v3: Disable detection of ATS and PRI" Will Deacon
2020-01-02 17:44 ` John Garry [this message]
2020-03-18 20:53 ` arm-smmu-v3 high cpu usage for NVMe Will Deacon
2020-03-19 12:54 ` John Garry
2020-03-19 18:43 ` Jean-Philippe Brucker
2020-03-20 10:41 ` John Garry
2020-03-20 11:18 ` Jean-Philippe Brucker
2020-03-20 16:20 ` John Garry
2020-03-20 16:33 ` Marc Zyngier
2020-03-23 9:03 ` John Garry
2020-03-23 9:16 ` Marc Zyngier
2020-03-24 9:18 ` John Garry
2020-03-24 10:43 ` Marc Zyngier
2020-03-24 11:55 ` John Garry
2020-03-24 12:07 ` Robin Murphy
2020-03-24 12:37 ` John Garry
2020-03-25 15:31 ` John Garry
2020-05-22 14:52 ` John Garry
2020-05-25 5:57 ` Song Bao Hua (Barry Song)
[not found] ` <482c00d5-8e6d-1484-820e-1e89851ad5aa@huawei.com>
2020-04-06 15:11 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a6e26d-6d0d-7f0d-f222-589812f701d2@huawei.com \
--to=john.garry@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=maz@kernel.org \
--cc=ming.lei@redhat.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).