From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2171EC433E7 for ; Tue, 21 Jul 2020 23:11:43 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F083E207BB for ; Tue, 21 Jul 2020 23:11:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F083E207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 93EB320453; Tue, 21 Jul 2020 23:11:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0tkcuM9ctE1Y; Tue, 21 Jul 2020 23:11:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 1D025203FB; Tue, 21 Jul 2020 23:11:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0A44CC088E; Tue, 21 Jul 2020 23:11:41 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 33497C016F for ; Tue, 21 Jul 2020 23:11:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 177B520453 for ; Tue, 21 Jul 2020 23:11:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JLI4HmUANgYo for ; Tue, 21 Jul 2020 23:11:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by silver.osuosl.org (Postfix) with ESMTPS id C09C62041F for ; Tue, 21 Jul 2020 23:11:37 +0000 (UTC) IronPort-SDR: kDJY7DG3gtmNepfKcwufbewgFqKcDGGmvI423RUsestsmfkdGmHpL7qM4UUhTTzFXJTDtV0ar0 bX0F2Ad9yT9A== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="214889055" X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="214889055" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 16:11:36 -0700 IronPort-SDR: UkdvjQPsfhGCtfdh2igIhtlU+U1RScxgkXHZLfUkKlV9tZJ34r5zXMkIfBCKgKaTZzegujEIOO FFJGEm/aNdNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="462248054" Received: from allen-box.sh.intel.com (HELO [10.239.159.139]) ([10.239.159.139]) by orsmga005.jf.intel.com with ESMTP; 21 Jul 2020 16:11:34 -0700 Subject: Re: [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated iommu To: "Limonciello, Mario" , Joerg Roedel References: <20200721001713.24282-1-baolu.lu@linux.intel.com> From: Lu Baolu Message-ID: Date: Wed, 22 Jul 2020 07:06:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: Ashok Raj , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Koba Ko , "iommu@lists.linux-foundation.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Limonciello, On 7/21/20 10:44 PM, Limonciello, Mario wrote: >> -----Original Message----- >> From: iommu On Behalf Of Lu >> Baolu >> Sent: Monday, July 20, 2020 7:17 PM >> To: Joerg Roedel >> Cc: Ashok Raj;linux-kernel@vger.kernel.org;stable@vger.kernel.org; Koba >> Ko;iommu@lists.linux-foundation.org >> Subject: [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated >> iommu >> >> The VT-d spec requires (10.4.4 Global Command Register, TE field) that: >> >> Hardware implementations supporting DMA draining must drain any in-flight >> DMA read/write requests queued within the Root-Complex before completing >> the translation enable command and reflecting the status of the command >> through the TES field in the Global Status register. >> >> Unfortunately, some integrated graphic devices fail to do so after some >> kind of power state transition. As the result, the system might stuck in >> iommu_disable_translation(), waiting for the completion of TE transition. >> >> This provides a quirk list for those devices and skips TE disabling if >> the qurik hits. >> >> Fixes:https://bugzilla.kernel.org/show_bug.cgi?id=208363 > That one is for TGL. > > I think you also want to add this one for ICL: > Fixes:https://bugzilla.kernel.org/show_bug.cgi?id=206571 > Do you mean someone have tested that this patch also fixes the problem described in 206571? Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu