From: Dave Hansen <dave.hansen@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Schofield, Alison" <alison.schofield@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Paul Mackerras <paulus@samba.org>, Christoph Hellwig <hch@lst.de>,
linux-s390@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
x86@kernel.org, Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
Vasily Gorbik <gor@linux.ibm.com>,
"Shutemov, Kirill" <kirill.shutemov@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Robin Murphy <robin.murphy@arm.com>,
lkml <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] treewide: Rename "unencrypted" to "decrypted"
Date: Tue, 17 Mar 2020 14:24:59 -0700 [thread overview]
Message-ID: <f3e520c6-f455-9c82-abfc-d014ca63eeb5@intel.com> (raw)
In-Reply-To: <20200317210602.GG15609@zn.tnic>
On 3/17/20 2:06 PM, Borislav Petkov wrote:
> On Tue, Mar 17, 2020 at 01:35:12PM -0700, Dave Hansen wrote:
>> On 3/17/20 4:18 AM, Borislav Petkov wrote:
>>> Back then when the whole SME machinery started getting mainlined, it
>>> was agreed that for simplicity, clarity and sanity's sake, the terms
>>> denoting encrypted and not-encrypted memory should be "encrypted" and
>>> "decrypted". And the majority of the code sticks to that convention
>>> except those two. So rename them.
>> Don't "unencrypted" and "decrypted" mean different things?
>>
>> Unencrypted to me means "encryption was never used for this data".
>>
>> Decrypted means "this was/is encrypted but here is a plaintext copy".
> Maybe but linguistical semantics is not the point here.
>
> The idea is to represent a "binary" concept of memory being encrypted
> or memory being not encrypted. And at the time we decided to use
> "encrypted" and "decrypted" for those two things.
Yeah, agreed. We're basically trying to name "!encrypted".
> Do you see the need to differentiate a third "state", so to speak, of
> memory which was never encrypted?
No, there are just two states. I just think the "!encrypted" case
should not be called "decrypted".
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-03-17 21:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 11:18 [PATCH] treewide: Rename "unencrypted" to "decrypted" Borislav Petkov
2020-03-17 20:35 ` Dave Hansen
2020-03-17 21:06 ` Borislav Petkov
2020-03-17 21:24 ` Dave Hansen [this message]
2020-03-17 21:31 ` Borislav Petkov
2020-03-17 21:34 ` Joe Perches
2020-03-17 22:01 ` Thomas Gleixner
2020-03-17 23:16 ` kbuild test robot
2020-03-17 23:51 ` kbuild test robot
2020-03-19 10:16 ` [PATCH -v2] " Borislav Petkov
2020-03-19 10:20 ` Christoph Hellwig
2020-03-19 10:28 ` Borislav Petkov
2020-03-19 11:06 ` Robin Murphy
2020-03-19 11:20 ` Borislav Petkov
2020-03-19 17:25 ` Thomas Gleixner
2020-03-19 17:42 ` Borislav Petkov
2020-03-19 23:53 ` Thomas Gleixner
2020-03-19 21:59 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e520c6-f455-9c82-abfc-d014ca63eeb5@intel.com \
--to=dave.hansen@intel.com \
--cc=alison.schofield@intel.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=gor@linux.ibm.com \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kirill.shutemov@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).