From: Jakub Kicinski <kuba@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Nathan Chancellor <nathan@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
"Michal Marek" <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH RFC/RFT 0/2] W=1 by default for Ethernet PHY subsystem
Date: Wed, 10 Feb 2021 10:43:29 -0800 [thread overview]
Message-ID: <20210210104329.3ecf3dd5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210210183917.GA1471624@nvidia.com>
On Wed, 10 Feb 2021 14:39:17 -0400 Jason Gunthorpe wrote:
> On Sun, Sep 20, 2020 at 04:53:51PM +0200, Andrew Lunn wrote:
>
> > How often are new W=1 flags added? My patch exported
> > KBUILD_CFLAGS_WARN1. How about instead we export
> > KBUILD_CFLAGS_WARN1_20200920. A subsystem can then sign up to being
> > W=1 clean as for the 20200920 definition of W=1.
>
> I think this is a reasonable idea.
>
> I'm hitting exactly the issue this series is trying to solve, Lee
> invested a lot of effort to make drivers/infiniband/ W=1 clean, but
> as maintainer I can't sustain this since there is no easy way to have
> a warning free compile and get all extra warnings. Also all my
> submitters are not running with W=1
>
> I need kbuild to get everyone on the same page to be able to sustain
> the warning clean up. We've already had a regression and it has only
> been a few weeks :(
Do you use patchwork? A little bit of automation is all you need,
really. kbuild bot is too slow, anyway.
> Andrew, would you consider respinning this series in the above form?
next prev parent reply other threads:[~2021-02-10 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 19:02 [PATCH RFC/RFT 0/2] W=1 by default for Ethernet PHY subsystem Andrew Lunn
2020-09-19 19:02 ` [PATCH RFC/RFT 1/2] scripts: Makefile.extrawarn: Add W=1 warnings to a symbol Andrew Lunn
2020-09-19 19:02 ` [PATCH RFC/RFT 2/2] net: phylib: Enable W=1 by default Andrew Lunn
2020-09-20 3:42 ` [PATCH RFC/RFT 0/2] W=1 by default for Ethernet PHY subsystem Masahiro Yamada
2020-09-20 14:53 ` Andrew Lunn
2021-02-10 18:39 ` Jason Gunthorpe
2021-02-10 18:43 ` Jakub Kicinski [this message]
2021-02-10 18:55 ` Jason Gunthorpe
2021-02-10 19:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210104329.3ecf3dd5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=jgg@nvidia.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).