linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	jdelvare@suse.com, linux@roeck-us.net, giometti@enneenne.com,
	abbotti@mev.co.uk, hsweeten@visionengravers.com, kw@linux.com,
	helgaas@kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kbuild@vger.kernel.org,
	masahiroy@kernel.org, michal.lkml@markovi.net,
	linuxarm@openeuler.org, prime.zeng@huawei.com
Subject: Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag
Date: Wed, 10 Feb 2021 11:42:03 +0000	[thread overview]
Message-ID: <20210210114203.jvhst2veqbx73r5g@maple.lan> (raw)
In-Reply-To: <1f0b2f37-db56-c220-dfe1-8c376031404f@hisilicon.com>

On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote:
> On 2021/2/8 18:47, Greg KH wrote:
> > On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote:
> >> On 2021/2/5 17:53, Greg KH wrote:
> >>> What does this offer in benefit of the existing way?  What is it fixing?
> >>> Why do this "churn"?
> >>
> >> currently we have added ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG in the Makefile
> >> of driver/base and driver/base/power, but not in the subdirectory
> >> driver/base/firmware_loader. we cannot turn the debug on for subdirectory
> >> firmware_loader if we config DEBUG_DRIVER and there is no kconfig option
> >> for the it.
> > 
> > Is that necessary?  Does that directory need it?
> 
> there are several debug prints in firmware_loader/main.c:
> 
> ./main.c:207:   pr_debug("%s: fw-%s fw_priv=%p\n", __func__, fw_name, fw_priv);
> ./main.c:245:                   pr_debug("batched request - sharing the same struct fw_priv and lookup for multiple requests\n");
> <snip>

Even if these are not in scope for CONFIG_DEBUG_DRVIER there is a
config option that would allow you to observe them without changing
any code (CONFIG_DYNAMIC_DEBUG).


Daniel.

  reply	other threads:[~2021-02-10 11:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  9:44 [PATCH 0/4] Use subdir-ccflags-* to inherit debug flag Yicong Yang
2021-02-05  9:44 ` [PATCH 1/4] driver core: " Yicong Yang
2021-02-05  9:53   ` Greg KH
2021-02-08 10:44     ` Yicong Yang
2021-02-08 10:47       ` Greg KH
2021-02-08 13:09         ` Yicong Yang
2021-02-10 11:42           ` Daniel Thompson [this message]
2021-02-24  9:56             ` Yicong Yang
2021-02-05  9:44 ` [PATCH 2/4] hwmon: " Yicong Yang
2021-02-05 18:28   ` Guenter Roeck
2021-02-05 20:08     ` Bjorn Helgaas
2021-02-08 10:51       ` Yicong Yang
2021-02-08 21:00       ` Guenter Roeck
2021-02-05  9:44 ` [PATCH 3/4] pps: " Yicong Yang
2021-02-05  9:44 ` [PATCH 4/4] staging: comedi: " Yicong Yang
2021-02-05  9:54   ` Greg KH
2021-02-06  0:52     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210210114203.jvhst2veqbx73r5g@maple.lan \
    --to=daniel.thompson@linaro.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=giometti@enneenne.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=hsweeten@visionengravers.com \
    --cc=jdelvare@suse.com \
    --cc=kw@linux.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linuxarm@openeuler.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=prime.zeng@huawei.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).