From: Michal Marek <mmarek@suse.com>
To: Filipe Brandenburger <filbranden@google.com>
Cc: linux-kbuild@vger.kernel.org, Greg Thelen <gthelen@google.com>,
Michael Davidson <md@google.com>,
Eugene Surovegin <surovegin@google.com>
Subject: Re: [PATCH] modpost: allow modpost to fail on warnings
Date: Thu, 18 Feb 2016 11:36:34 +0100 [thread overview]
Message-ID: <56C59EB2.6080207@suse.com> (raw)
In-Reply-To: <1455747939-34515-1-git-send-email-filbranden@google.com>
On 2016-02-17 23:25, Filipe Brandenburger wrote:
> Set KBUILD_MODPOST_FAIL_ON_WARNINGS to a non-empty value to make the
> kbuild fail when modpost generates any warnings.
>
> Tested:
> Replaced ntp_clear() with ntp_init() in kernel/time/timekeeping.c,
> which produces a modpost warning since the latter is marked __init.
> Confirmed that the build failed with a hard error.
>
> $ make bzImage modules KBUILD_MODPOST_FAIL_ON_WARNINGS=1
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> CHK include/generated/bounds.h
> CHK include/generated/timeconst.h
> CHK include/generated/asm-offsets.h
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CC kernel/time/timekeeping.o
> LD kernel/time/built-in.o
> LD kernel/built-in.o
> LINK vmlinux
> LD vmlinux.o
> MODPOST vmlinux.o
> WARNING: modpost: Found 1 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> scripts/Makefile.modpost:100: recipe for target 'vmlinux.o' failed
> make[1]: *** [vmlinux.o] Error 2
> Makefile:936: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 2
This is not a good test case, because we already fail here if
CONFIG_SECTION_MISMATCH_WARN_ONLY=n.
Michal
next prev parent reply other threads:[~2016-02-18 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 22:25 [PATCH] modpost: allow modpost to fail on warnings Filipe Brandenburger
2016-02-18 10:36 ` Michal Marek [this message]
2020-09-18 21:50 Pierre-Louis Bossart
2020-09-19 6:21 ` Masahiro Yamada
2020-09-21 14:50 ` Pierre-Louis Bossart
2020-09-24 17:22 ` Masahiro Yamada
2020-09-24 18:13 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C59EB2.6080207@suse.com \
--to=mmarek@suse.com \
--cc=filbranden@google.com \
--cc=gthelen@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=md@google.com \
--cc=surovegin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).