From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Shuah Khan <shuah@kernel.org>, Kees Cook <keescook@chromium.org>,
Anders Roxell <anders.roxell@linaro.org>,
Tim Bird <Tim.Bird@sony.com>,
kernel@collabora.com,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] Makefile: replace headers_install with headers for kselftest
Date: Tue, 19 Jul 2022 19:31:46 +0200 [thread overview]
Message-ID: <81241d70-7952-2f55-9181-d18679068998@collabora.com> (raw)
In-Reply-To: <CAK7LNAQ4iMBwu4bOmmOrMudNH49ruz-7AK_H3-ceTixd=G+brQ@mail.gmail.com>
On 19/07/2022 17:06, Masahiro Yamada wrote:
> On Tue, Jul 19, 2022 at 9:37 PM Guillaume Tucker
> <guillaume.tucker@collabora.com> wrote:
>>
>> On 14/07/2022 22:45, Shuah Khan wrote:
>>> On 7/13/22 12:33 AM, Guillaume Tucker wrote:
>>>> Replace headers_install with headers as kselftest uses the header
>>>> files from within the kernel tree rather than from a system-wide
>>>> installation.
>>>>
>>>> We can still run this directly:
>>>>
>>>> $ make O=build kselftest-all
>>>>
>>>> and when building from the selftests directory:
>>>>
>>>> $ make O=build headers
>>>> $ make O=build -C tools/testing/selftests all
>>>>
>>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>>> Reported-by: Masahiro Yamada <masahiroy@kernel.org>
>>>> ---
>>>> Makefile | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Makefile b/Makefile
>>>> index fb2f3bb53a6b..5c934d16664c 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -1347,10 +1347,10 @@ tools/%: FORCE
>>>> # Kernel selftest
>>>> PHONY += kselftest
>>>> -kselftest: headers_install
>>>> +kselftest: headers
>>>> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>>>> -kselftest-%: headers_install FORCE
>>>> +kselftest-%: headers FORCE
>>>> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $*
>>>> PHONY += kselftest-merge
>>>>
>>>
>>> Thank you for taking care of this. This will go through kbuild?
>>
>> You're welcome.
>>
>> Masahiro-san,
>>
>> A you OK with applying this in the kbuild tree ahead of the
>> upcoming merge window?
>
>
> No.
>
> This is a fix-up patch on top of the previous one [1],
> which was applied to the kselftest tree.
>
> This cannot apply to the kbuild tree.
OK thank you for confirming.
Shuah, I guess you're happy to apply it to the kselftest tree
instead then?
Guillaume
> [1]: https://lore.kernel.org/linux-kbuild/168ede35-12e0-c535-9d94-23b65a1beb28@collabora.com/T/#mb8ec7004f7c9b89fbb50c19022760e19701af7f6
>
>
>
>
>
>
>> Best wishes,
>> Guillaume
>>
>>> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>> thanks,
>>> -- Shuah
>>>
>
>
>
next prev parent reply other threads:[~2022-07-19 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 6:33 [PATCH] Makefile: replace headers_install with headers for kselftest Guillaume Tucker
2022-07-14 20:45 ` Shuah Khan
2022-07-19 12:37 ` Guillaume Tucker
2022-07-19 15:06 ` Masahiro Yamada
2022-07-19 17:31 ` Guillaume Tucker [this message]
2022-07-27 0:13 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81241d70-7952-2f55-9181-d18679068998@collabora.com \
--to=guillaume.tucker@collabora.com \
--cc=Tim.Bird@sony.com \
--cc=anders.roxell@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).