From: Masahiro Yamada <masahiroy@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Kbuild.include: remove leftover comment for filechk utility
Date: Sat, 17 Oct 2020 09:52:10 +0900 [thread overview]
Message-ID: <CAK7LNAQ+5vd6rcgta3VMAMxDMkbw4h8ngohPA1fUjSPXXLjAZg@mail.gmail.com> (raw)
In-Reply-To: <20201016125846.8156-1-linux@rasmusvillemoes.dk>
On Fri, Oct 16, 2020 at 9:59 PM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> After commit 43fee2b23895 ("kbuild: do not redirect the first
> prerequisite for filechk"), the rule is no longer automatically passed
> $< as stdin, so remove the stale comment.
>
> Fixes: 43fee2b23895 ("kbuild: do not redirect the first prerequisite for filechk")
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
Applied to linux-kbuild. Thanks.
> scripts/Kbuild.include | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index 83a1637417e5..08e011175b4c 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -56,8 +56,6 @@ kecho := $($(quiet)kecho)
> # - If no file exist it is created
> # - If the content differ the new file is used
> # - If they are equal no change, and no timestamp update
> -# - stdin is piped in from the first prerequisite ($<) so one has
> -# to specify a valid file as first prerequisite (often the kbuild file)
> define filechk
> $(Q)set -e; \
> mkdir -p $(dir $@); \
> --
> 2.23.0
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2020-10-17 5:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 12:58 [PATCH] Kbuild.include: remove leftover comment for filechk utility Rasmus Villemoes
2020-10-17 0:52 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQ+5vd6rcgta3VMAMxDMkbw4h8ngohPA1fUjSPXXLjAZg@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).