From: Rob Herring <robh@kernel.org>
To: Anshul Dalal <anshulusr@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Shuah Khan <skhan@linuxfoundation.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: dac: add MCP4821
Date: Wed, 20 Dec 2023 07:58:26 -0600 [thread overview]
Message-ID: <170308069917.116385.808780928089948753.robh@kernel.org> (raw)
In-Reply-To: <20231219090252.818754-1-anshulusr@gmail.com>
On Tue, 19 Dec 2023 14:32:50 +0530, Anshul Dalal wrote:
> Adds support for MCP48xx series of DACs.
>
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/22244B.pdf #MCP48x1
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/20002249B.pdf #MCP48x2
> Signed-off-by: Anshul Dalal <anshulusr@gmail.com>
>
> ---
>
> Changes for v4:
> - Removed 'Reviewed-by: Conor Dooley' due to changes
> - Renamed shdn-gpios to powerdown-gpios to conform to
> gpio-consumer-common.yaml
>
> Changes for v3:
> - Added gpios for ldac and shutdown pins
> - Added spi-cpha and spi-cpol for the SPI mode 0 and 3
>
> Changes for v2:
> - Changed order in device table to numerical
> - Made vdd_supply required
> - Added 'Reviewed-by: Conor Dooley'
>
> Previous versions:
> v3: https://lore.kernel.org/lkml/20231218164735.787199-1-anshulusr@gmail.com/
> v2: https://lore.kernel.org/lkml/20231217180836.584828-1-anshulusr@gmail.com/
> v1: https://lore.kernel.org/lkml/20231117073040.685860-1-anshulusr@gmail.com/
> ---
> .../bindings/iio/dac/microchip,mcp4821.yaml | 86 +++++++++++++++++++
> 1 file changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4821.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2023-12-20 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 9:02 [PATCH v4 1/2] dt-bindings: iio: dac: add MCP4821 Anshul Dalal
2023-12-19 9:02 ` [PATCH v4 2/2] iio: dac: driver for MCP4821 Anshul Dalal
2023-12-20 14:48 ` Jonathan Cameron
2023-12-20 13:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170308069917.116385.808780928089948753.robh@kernel.org \
--to=robh@kernel.org \
--cc=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).