Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/izabela-bakollari-gmail-com/dropwatch-Support-monitoring-of-dropped-frames/20200708-011806 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d47a72152097d7be7cfc453d205196c0aa976c33 config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): net/core/drop_monitor.c: In function 'net_dm_cmd_ifc_trace': >> net/core/drop_monitor.c:1375:47: error: 'struct net_device' has no member named 'ifname'; did you mean 'name'? 1375 | rc = net_dm_interface_stop(net, interface->ifname); | ^~~~~~ | name vim +1375 net/core/drop_monitor.c 1357 1358 static int net_dm_cmd_ifc_trace(struct sk_buff *skb, struct genl_info *info) 1359 { 1360 struct net *net = sock_net(skb->sk); 1361 char ifname[IFNAMSIZ]; 1362 int rc; 1363 1364 memset(ifname, 0, IFNAMSIZ); 1365 nla_strlcpy(ifname, info->attrs[NET_DM_ATTR_IFNAME], IFNAMSIZ - 1); 1366 1367 switch (info->genlhdr->cmd) { 1368 case NET_DM_CMD_START_IFC: 1369 rc = net_dm_interface_start(net, ifname); 1370 if (rc) 1371 return rc; 1372 break; 1373 case NET_DM_CMD_STOP_IFC: 1374 if (interface) { > 1375 rc = net_dm_interface_stop(net, interface->ifname); 1376 return rc; 1377 } else { 1378 return -ENODEV; 1379 } 1380 } 1381 1382 return 0; 1383 } 1384 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org