From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75475C433DF for ; Sun, 16 Aug 2020 20:24:53 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 499482078D for ; Sun, 16 Aug 2020 20:24:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 499482078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 47B8887E3C; Sun, 16 Aug 2020 20:24:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 189nbf7CQR+Q; Sun, 16 Aug 2020 20:24:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 2D64287CB2; Sun, 16 Aug 2020 20:24:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1AE5DC0889; Sun, 16 Aug 2020 20:24:51 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 11FADC0051 for ; Sun, 16 Aug 2020 20:24:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0EE9885C67 for ; Sun, 16 Aug 2020 20:24:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4zGZ4sbxbNQn for ; Sun, 16 Aug 2020 20:24:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 53FCC85C4A for ; Sun, 16 Aug 2020 20:24:47 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1C02720023; Sun, 16 Aug 2020 22:24:44 +0200 (CEST) Date: Sun, 16 Aug 2020 22:24:42 +0200 From: Sam Ravnborg To: Vaibhav Gupta Message-ID: <20200816202442.GB1426650@ravnborg.org> References: <20200810165458.GA292825@ravnborg.org> <20200810185723.15540-1-vaibhavgupta40@gmail.com> <20200810185723.15540-10-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200810185723.15540-10-vaibhavgupta40@gmail.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=MP0Wb9vCekDogQPHZHEA:9 a=CjuIK1q_8ugA:10 Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Antonino Daplas , Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Russell King , dri-devel@lists.freedesktop.org, linux-geode@lists.infradead.org, Bjorn Helgaas , Andres Salomon , Bjorn Helgaas , Paul Mackerras , linux-kernel-mentees@lists.linuxfoundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Linux-kernel-mentees] [PATCH v2 09/12] fbdev: i740fb: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Hi Vaibhav On Tue, Aug 11, 2020 at 12:27:20AM +0530, Vaibhav Gupta wrote: > Drivers should do only device-specific jobs. But in general, drivers using > legacy PCI PM framework for .suspend()/.resume() have to manage many PCI > PM-related tasks themselves which can be done by PCI Core itself. This > brings extra load on the driver and it directly calls PCI helper functions > to handle them. > > Switch to the new generic framework by updating function signatures and > define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove > unnecessary calls to the PCI Helper functions along with the legacy > .suspend & .resume bindings. > > Signed-off-by: Vaibhav Gupta I several of the drivers I briefly looked at a new set of helpers were introduced for the different types of pm actions. They then called a more generic function that uses the passes enumeration to decide what to do. But in this driver the test "state.event == PM_EVENT_FREEZE" is dropped and there is no freeze operation. Please explain this change so the reader is not left wondering. Sam > --- > drivers/video/fbdev/i740fb.c | 40 +++++++++++++++--------------------- > 1 file changed, 16 insertions(+), 24 deletions(-) > > diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c > index c65ec7386e87..8d7f06fc8a5a 100644 > --- a/drivers/video/fbdev/i740fb.c > +++ b/drivers/video/fbdev/i740fb.c > @@ -1175,16 +1175,11 @@ static void i740fb_remove(struct pci_dev *dev) > } > } > > -#ifdef CONFIG_PM > -static int i740fb_suspend(struct pci_dev *dev, pm_message_t state) > +static int __maybe_unused i740fb_suspend(struct device *dev) > { > - struct fb_info *info = pci_get_drvdata(dev); > + struct fb_info *info = dev_get_drvdata(dev); > struct i740fb_par *par = info->par; > > - /* don't disable console during hibernation and wakeup from it */ > - if (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW) > - return 0; > - > console_lock(); > mutex_lock(&(par->open_lock)); > > @@ -1197,19 +1192,15 @@ static int i740fb_suspend(struct pci_dev *dev, pm_message_t state) > > fb_set_suspend(info, 1); > > - pci_save_state(dev); > - pci_disable_device(dev); > - pci_set_power_state(dev, pci_choose_state(dev, state)); > - > mutex_unlock(&(par->open_lock)); > console_unlock(); > > return 0; > } > > -static int i740fb_resume(struct pci_dev *dev) > +static int __maybe_unused i740fb_resume(struct device *dev) > { > - struct fb_info *info = pci_get_drvdata(dev); > + struct fb_info *info = dev_get_drvdata(dev); > struct i740fb_par *par = info->par; > > console_lock(); > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev) > if (par->ref_count == 0) > goto fail; > > - pci_set_power_state(dev, PCI_D0); > - pci_restore_state(dev); > - if (pci_enable_device(dev)) > - goto fail; > - > i740fb_set_par(info); > fb_set_suspend(info, 0); > > @@ -1231,10 +1217,17 @@ static int i740fb_resume(struct pci_dev *dev) > console_unlock(); > return 0; > } > -#else > -#define i740fb_suspend NULL > -#define i740fb_resume NULL > -#endif /* CONFIG_PM */ > + > +static const struct dev_pm_ops i740fb_pm_ops = { > +#ifdef CONFIG_PM_SLEEP > + .suspend = i740fb_suspend, > + .resume = i740fb_resume, > + .freeze = NULL, > + .thaw = i740fb_resume, > + .poweroff = i740fb_suspend, > + .restore = i740fb_resume, > +#endif /* CONFIG_PM_SLEEP */ > +}; > > #define I740_ID_PCI 0x00d1 > #define I740_ID_AGP 0x7800 > @@ -1251,8 +1244,7 @@ static struct pci_driver i740fb_driver = { > .id_table = i740fb_id_table, > .probe = i740fb_probe, > .remove = i740fb_remove, > - .suspend = i740fb_suspend, > - .resume = i740fb_resume, > + .driver.pm = &i740fb_pm_ops, > }; > > #ifndef MODULE > -- > 2.27.0 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees