From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Vaibhav Gupta" <vaibhav.varodek@gmail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
"Jia-Ju Bai" <baijiaju1990@gmail.com>,
"Alex Shi" <alex.shi@linux.alibaba.com>,
"Jiri Slaby" <jslaby@suse.cz>, "Christoph Hellwig" <hch@lst.de>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Prabhakar Kushwaha" <pkushwaha@marvell.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Hans de Goede" <hdegoede@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [Linux-kernel-mentees] [PATCH v3] ata: use generic power management
Date: Tue, 18 Aug 2020 18:33:29 +0530 [thread overview]
Message-ID: <20200818130329.GA39194@gmail.com> (raw)
In-Reply-To: <11190a0b-1009-caf8-9cbe-6cf296b614bf@kernel.dk>
On Mon, Aug 17, 2020 at 07:06:03AM -0700, Jens Axboe wrote:
> On 8/17/20 2:25 AM, Vaibhav Gupta wrote:
> > Hello,
> >
> > I am working to upgrade power management framework support for PCI drivers, as
> > my project under the Linux Kernel Mentorship Program.
> >
> > The ultimate goal is to completely remove the legacy framework. And for this we
> > need to remove ".suspend" and ".resume" pointers from "struct pci_driver".
> >
> > The patch is doing the change for the same. The actual suspend() and
> > resume() callbacks are defined in drivers/ata/libata-core.c and are exported.
> > Which are then used by other files.
> >
> > Thus removing those pointers, included 54 files in this patch. Although, the
> > actual changes are done in few files only. The changes should work fine as I
> > have done similar changes for other drivers too which made their way into the
> > kernel. Still, tests on few ata devices are necessary.
>
> Didn't we agree to split this up into separate patches??
>
> > I tried but unfortunately, I couldn't find or arrange devices to test upon. I
> > have added the authors of the previous commit(s) for respective drivers as
> > recipients. It would be very helpful if someone can test it on a device.
>
> Does qemu support any of the affected drivers?
>
Hello Jens,
Yes we discussed about splitting it and I will surely do it. I just thought that
still it has not got tested and in that case keeping check on patch-series with
55+ patches may become somewhat messy. Moreover, to test any driver one will
have to apply the patch for libata-core and then that of the driver.
So, I sent this v3 in order to get some help for the testing purpose. Once it
goes successful, I can split it and send it for the submission.
I am not sure about qemu, I haven't checked for it. Qemu will be appropriate
for testing power management for .suspend() and .resume() callbacks?
Thanks
Vaibhav Gupta
> --
> Jens Axboe
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-08-18 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:22 [Linux-kernel-mentees] [PATCH v3] ata: use generic power management Vaibhav Gupta
2020-08-17 9:25 ` Vaibhav Gupta
2020-08-17 14:06 ` Jens Axboe
2020-08-18 13:03 ` Vaibhav Gupta [this message]
2020-08-19 18:40 ` Jens Axboe
2020-08-19 18:51 ` Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818130329.GA39194@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=alex.shi@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=baijiaju1990@gmail.com \
--cc=bhelgaas@google.com \
--cc=gustavoars@kernel.org \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=helgaas@kernel.org \
--cc=javier@osg.samsung.com \
--cc=jslaby@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=paul.gortmaker@windriver.com \
--cc=pkushwaha@marvell.com \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=vaibhav.varodek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).