From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Sean Young <sean@mess.org>
Cc: Abylay Ospan <aospan@netup.ru>, Sergey Kozlov <serjk@netup.ru>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH v1] [media] netup_unidvb: use generic power management
Date: Sun, 30 Aug 2020 14:13:52 +0530 [thread overview]
Message-ID: <20200830084352.GA36870@gmail.com> (raw)
In-Reply-To: <20200830081004.GA17376@gofer.mess.org>
On Sun, Aug 30, 2020 at 09:10:04AM +0100, Sean Young wrote:
> On Tue, Jul 28, 2020 at 02:57:17PM +0530, Vaibhav Gupta wrote:
> > The .suspend() and .resume() callbacks are not defined for this driver.
> > Still, their power management structure follows the legacy framework. To
> > bring it under the generic framework, simply remove the binding of
> > callbacks from "struct pci_driver".
>
> Unlisted fields in a static struct initializer will get set to 0 (or NULL
> for pointers) already. Removing the NULL initializers will not change
> anything.
>
> Possibly you want to remove the redundant initializers but your commit
> message should say so.
>
>
> Sean
>
Hello Sean,
Yes, you are right. I mentioned a general commit message. I will send a v2 with
suggested changes.
Thank you
Vaibhav Gupta
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-08-30 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 9:27 [Linux-kernel-mentees] [PATCH v1] [media] netup_unidvb: use generic power management Vaibhav Gupta
2020-07-28 12:38 ` Vaibhav Gupta
2020-08-30 8:10 ` Sean Young
2020-08-30 8:43 ` Vaibhav Gupta [this message]
2020-08-30 9:44 ` [Linux-kernel-mentees] [PATCH v2] netup_unidvb: drop initialization of PM pointers Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830084352.GA36870@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=aospan@netup.ru \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=serjk@netup.ru \
--cc=vaibhav.varodek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).