linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <bjorn@helgaas.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Adam Radford <aradford@gmail.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
	Hannes Reinecke <hare@suse.com>,
	Bradley Grove <linuxdrivers@attotech.com>,
	John Garry <john.garry@huawei.com>,
	Don Brace <don.brace@microsemi.com>,
	James Smart <james.smart@broadcom.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Jack Wang <jinpu.wang@cloud.ionos.com>
Cc: linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
	esc.storagedev@microsemi.com, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	megaraidlinux.pdl@broadcom.com
Subject: [Linux-kernel-mentees] [PATCH v3 28/28] scsi: pmcraid: use generic power management
Date: Thu,  1 Oct 2020 17:55:11 +0530	[thread overview]
Message-ID: <20201001122511.1075420-29-vaibhavgupta40@gmail.com> (raw)
In-Reply-To: <20201001122511.1075420-1-vaibhavgupta40@gmail.com>

Drivers should do only device-specific jobs. But in general, drivers using
legacy PCI PM framework for .suspend()/.resume() have to manage many PCI
PM-related tasks themselves which can be done by PCI Core itself. This
brings extra load on the driver and it directly calls PCI helper functions
to handle them.

Switch to the new generic framework by updating function signatures and
define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove
unnecessary calls to the PCI Helper functions along with the legacy
.suspend & .resume bindings.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/scsi/pmcraid.c | 43 ++++++++++--------------------------------
 1 file changed, 10 insertions(+), 33 deletions(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 7674b8481f35..bbf7fc8d5a2c 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -5237,53 +5237,37 @@ static void pmcraid_remove(struct pci_dev *pdev)
 	return;
 }
 
-#ifdef CONFIG_PM
 /**
  * pmcraid_suspend - driver suspend entry point for power management
- * @pdev:   PCI device structure
- * @state:  PCI power state to suspend routine
+ * @dev:   Device structure
  *
  * Return Value - 0 always
  */
-static int pmcraid_suspend(struct pci_dev *pdev, pm_message_t state)
+static int __maybe_unused pmcraid_suspend(struct device *dev)
 {
+	struct pci_dev *pdev = to_pci_dev(dev);
 	struct pmcraid_instance *pinstance = pci_get_drvdata(pdev);
 
 	pmcraid_shutdown(pdev);
 	pmcraid_disable_interrupts(pinstance, ~0);
 	pmcraid_kill_tasklets(pinstance);
-	pci_set_drvdata(pinstance->pdev, pinstance);
 	pmcraid_unregister_interrupt_handler(pinstance);
-	pci_save_state(pdev);
-	pci_disable_device(pdev);
-	pci_set_power_state(pdev, pci_choose_state(pdev, state));
 
 	return 0;
 }
 
 /**
  * pmcraid_resume - driver resume entry point PCI power management
- * @pdev: PCI device structure
+ * @dev: Device structure
  *
  * Return Value - 0 in case of success. Error code in case of any failure
  */
-static int pmcraid_resume(struct pci_dev *pdev)
+static int __maybe_unused pmcraid_resume(struct device *dev)
 {
+	struct pci_dev *pdev = to_pci_dev(dev);
 	struct pmcraid_instance *pinstance = pci_get_drvdata(pdev);
 	struct Scsi_Host *host = pinstance->host;
-	int rc;
-
-	pci_set_power_state(pdev, PCI_D0);
-	pci_restore_state(pdev);
-
-	rc = pci_enable_device(pdev);
-
-	if (rc) {
-		dev_err(&pdev->dev, "resume: Enable device failed\n");
-		return rc;
-	}
-
-	pci_set_master(pdev);
+	int rc = 0;
 
 	if (sizeof(dma_addr_t) == 4 ||
 	    dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)))
@@ -5336,18 +5320,10 @@ static int pmcraid_resume(struct pci_dev *pdev)
 	scsi_host_put(host);
 
 disable_device:
-	pci_disable_device(pdev);
 
 	return rc;
 }
 
-#else
-
-#define pmcraid_suspend NULL
-#define pmcraid_resume  NULL
-
-#endif /* CONFIG_PM */
-
 /**
  * pmcraid_complete_ioa_reset - Called by either timer or tasklet during
  *				completion of the ioa reset
@@ -5835,6 +5811,8 @@ static int pmcraid_probe(struct pci_dev *pdev,
 	return -ENODEV;
 }
 
+static SIMPLE_DEV_PM_OPS(pmcraid_pm_ops, pmcraid_suspend, pmcraid_resume);
+
 /*
  * PCI driver structure of pmcraid driver
  */
@@ -5843,8 +5821,7 @@ static struct pci_driver pmcraid_driver = {
 	.id_table = pmcraid_pci_table,
 	.probe = pmcraid_probe,
 	.remove = pmcraid_remove,
-	.suspend = pmcraid_suspend,
-	.resume = pmcraid_resume,
+	.driver.pm = &pmcraid_pm_ops,
 	.shutdown = pmcraid_shutdown
 };
 
-- 
2.28.0

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2020-10-01 12:32 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 12:24 [Linux-kernel-mentees] [PATCH v3 00/28] scsi: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 01/28] scsi: megaraid_sas: Drop PCI wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 02/28] scsi: megaraid_sas: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 03/28] scsi: megaraid_sas: update function description Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 04/28] scsi: aacraid: Drop pci_enable_wake() from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 05/28] scsi: aacraid: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 06/28] scsi: aic7xxx: " Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 07/28] scsi: aic79xx: " Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 08/28] scsi: arcmsr: Drop PCI wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 09/28] scsi: arcmsr: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 10/28] scsi: esas2r: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 11/28] scsi: esas2r: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 12/28] scsi: hisi_sas_v3_hw: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 13/28] scsi: hisi_sas_v3_hw: use generic power management Vaibhav Gupta
2020-10-27 17:11   ` John Garry
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 14/28] scsi: mpt3sas_scsih: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 15/28] scsi: mpt3sas_scsih: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 16/28] scsi: lpfc: " Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 17/28] scsi: pm_8001: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:53   ` Jinpu Wang
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 18/28] scsi: pm_8001: use generic power management Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 19/28] scsi: hpsa: " Vaibhav Gupta
2020-10-27 16:16   ` Don.Brace--- via Linux-kernel-mentees
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 20/28] scsi: 3w-9xxx: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 21/28] scsi: 3w-9xxx: use generic power management Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 22/28] scsi: 3w-sas: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 23/28] scsi: 3w-sas: use generic power management Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 24/28] scsi: mvumi: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 25/28] scsi: mvumi: use generic power management Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 26/28] scsi: mvumi: update function description Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 27/28] scsi: pmcraid: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:25 ` Vaibhav Gupta [this message]
2020-10-01 12:33 ` [Linux-kernel-mentees] [PATCH v3 00/28] scsi: use generic power management Vaibhav Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001122511.1075420-29-vaibhavgupta40@gmail.com \
    --to=vaibhavgupta40@gmail.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=aacraid@microsemi.com \
    --cc=aradford@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn@helgaas.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=don.brace@microsemi.com \
    --cc=esc.storagedev@microsemi.com \
    --cc=hare@suse.com \
    --cc=helgaas@kernel.org \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=john.garry@huawei.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxdrivers@attotech.com \
    --cc=martin.petersen@oracle.com \
    --cc=megaraidlinux.pdl@broadcom.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=vaibhav.varodek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).