From: Utkarsh Verma <utkarshverma294@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v2] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions
Date: Wed, 4 Aug 2021 00:07:35 +0530 [thread overview]
Message-ID: <20210803183735.2525-1-utkarshverma294@gmail.com> (raw)
In-Reply-To: <CAKXUXMxJ9CKP1nftTWmP-UTaMMyuOtoNYz4SQYrDPP9PdaRp4A@mail.gmail.com>
Fix checkpatch warnings:
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Utkarsh Verma <utkarshverma294@gmail.com>
---
drivers/usb/serial/iuu_phoenix.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index 19753611e..0be3b5e1e 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -1188,20 +1188,20 @@ MODULE_AUTHOR("Alain Degreffe eczema@ecze.com");
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");
-module_param(xmas, bool, S_IRUGO | S_IWUSR);
+module_param(xmas, bool, 0644);
MODULE_PARM_DESC(xmas, "Xmas colors enabled or not");
-module_param(boost, int, S_IRUGO | S_IWUSR);
+module_param(boost, int, 0644);
MODULE_PARM_DESC(boost, "Card overclock boost (in percent 100-500)");
-module_param(clockmode, int, S_IRUGO | S_IWUSR);
+module_param(clockmode, int, 0644);
MODULE_PARM_DESC(clockmode, "Card clock mode (1=3.579 MHz, 2=3.680 MHz, "
"3=6 Mhz)");
-module_param(cdmode, int, S_IRUGO | S_IWUSR);
+module_param(cdmode, int, 0644);
MODULE_PARM_DESC(cdmode, "Card detect mode (0=none, 1=CD, 2=!CD, 3=DSR, "
"4=!DSR, 5=CTS, 6=!CTS, 7=RING, 8=!RING)");
-module_param(vcc_default, int, S_IRUGO | S_IWUSR);
+module_param(vcc_default, int, 0644);
MODULE_PARM_DESC(vcc_default, "Set default VCC (either 3 for 3.3V or 5 "
"for 5V). Default to 5.");
--
2.17.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-08-03 18:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 6:46 Linux Kernel: Checkpatch Documentation Mentorship Tasks Utkarsh Verma
2021-07-17 7:23 ` Lukas Bulwahn
2021-07-24 22:06 ` Utkarsh Verma
2021-07-26 10:40 ` Lukas Bulwahn
2021-08-03 14:17 ` [PATCH] Documentation: checkpatch: Add SPLIT_STRING message Utkarsh Verma
2021-08-03 14:52 ` Dwaipayan Ray
2021-08-03 18:13 ` Utkarsh Verma
2021-08-03 18:20 ` Lukas Bulwahn
2021-08-04 18:09 ` [PATCH v2] " Utkarsh Verma
2021-08-03 14:19 ` [PATCH] Documentation: checkpatch: Add SYMBOLIC_PERMS message Utkarsh Verma
2021-08-03 14:20 ` [PATCH] Documentation: checkpatch: Add TRAILING_SEMICOLON message Utkarsh Verma
2021-08-03 15:20 ` Dwaipayan Ray
2021-08-03 21:19 ` [PATCH v2] " Utkarsh Verma
2021-08-05 13:49 ` Dwaipayan Ray
2021-08-20 19:53 ` [PATCH v3] " Utkarsh Verma
2021-08-22 17:29 ` Dwaipayan Ray
2021-08-03 14:20 ` [PATCH] USB: serial: iuu_phoenix: fix checkpatch memset warning Utkarsh Verma
2021-08-03 14:21 ` [PATCH] USB: serial: iuu_phoenix: fix quoted string split across lines Utkarsh Verma
2021-08-05 13:52 ` Dwaipayan Ray
2021-08-05 14:20 ` Lukas Bulwahn
2021-08-06 13:12 ` Utkarsh Verma
2021-08-25 8:22 ` [PATCH v2] " Utkarsh Verma
2021-08-03 14:21 ` [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions Utkarsh Verma
2021-08-03 18:11 ` Lukas Bulwahn
2021-08-03 18:37 ` Utkarsh Verma [this message]
2021-08-20 10:09 ` [PATCH v2] " Lukas Bulwahn
2021-08-20 19:08 ` Utkarsh Verma
2021-08-04 19:12 ` [PATCH] " Utkarsh Verma
2021-08-05 9:26 ` Lukas Bulwahn
2021-08-06 19:12 ` Utkarsh Verma
2021-08-03 16:36 ` Linux Kernel: Checkpatch Documentation Mentorship Tasks Utkarsh Verma
2021-08-03 18:07 ` Lukas Bulwahn
2021-08-03 21:37 ` [PATCH v2] Documentation: checkpatch: Add SYMBOLIC_PERMS message Utkarsh Verma
2021-08-03 21:49 ` Dwaipayan Ray
2021-08-04 15:31 ` [PATCH v3] " Utkarsh Verma
2021-08-05 13:51 ` Dwaipayan Ray
2021-08-06 13:46 ` Utkarsh Verma
2021-08-06 19:56 ` Dwaipayan Ray
2021-08-06 20:03 ` Lukas Bulwahn
2021-08-06 20:10 ` [PATCH v4] " Utkarsh Verma
2021-08-22 17:52 ` Dwaipayan Ray
2021-08-23 7:18 ` Lukas Bulwahn
2021-08-24 22:13 ` [PATCH v5] " Utkarsh Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803183735.2525-1-utkarshverma294@gmail.com \
--to=utkarshverma294@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).