From: "Ayush" <ayush@disroot.org>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve checkpatch.pl"
Date: Mon, 24 Aug 2020 10:06:36 +0000 [thread overview]
Message-ID: <32595de077ee7d674a628df11c58152f@disroot.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2008221002290.12792@felia>
August 22, 2020 1:36 PM, "Lukas Bulwahn" <lukas.bulwahn@gmail.com> wrote:
> On Fri, 21 Aug 2020, Ayush wrote:
>
>> August 17, 2020 3:13 PM, "Lukas Bulwahn" <lukas.bulwahn@gmail.com> wrote:
>>
>> Dear Ayush,
>>
>> The zeroth task is to learn suitable netiquette for the communication with
>> the kernel community.
>>
>> First, please do not top-post.
>>
>> A: Because we read from top to bottom, left to right.
>> Q: Why should I start my reply below the quoted text?
>>
>> A: Because it messes up the order in which people normally read text.
>> Q: Why is top-posting such a bad thing?
>>
>> A: The lost context.
>> Q: What makes top-posted replies harder to read than bottom-posted?
>>
>> A: Yes.
>> Q: Should I trim down the quoted part of an email to which I'm
>> replying?
>>
>> Second, please always CC: linux-kernel-mentees@lists.linuxfoundation.org.
>>
>> Third, set up your email client according to the kernel community rules.
>>
>> Then, the first task is to run checkpatch.pl on a few kernel patches and
>> collect the results. When you have that, please share your script with
>> me, e.g., in a github repository.
>>
>> Hints to the first task:
>>
>> Can you create a list of all non-merge commits that were added in the
>> version v5.8 of the kernel, i.e., all non-merge commits that are in v5.8
>> and not already in v5.7?
>>
>> Can you share the script/command you executed and the resulting list on
>> github?
>>
>> Can you run your script on all commits of this list above and record
>> all checkpatch.pl reports, and store them in your github repository?
>>
>> Can you suggest ideas how to aggregate the findings and create a
>> statistics? For example: Which type of error is reported most?
>> Can you implement that idea?
>>
>> I also suggest to have a look at
>> the options ./scripts/checkpatch.pl --list-types and
>> ./scripts/checkpatch.pl --show-types. The option --show-types changes
>> the output of checkpatch.pl to list type identifiers, so it is easier
>> to parse and aggregate the output.
>>
>> Please also share the script you create for that purpose on your
>> github repository.
>>
>> The second task is to pick one warning that appears often and improve
>> checkpatch.pl to handle that better and get it accepted by the kernel
>> community.
>>
>> Hints to the second task follow when the first task is solved.
>>
>> If you fail on any of those tasks, you are out of the selection process.
>>
>> Lukas
>>
>> Sir,
>>
>> I have attempted the task 1 and pushed the same to GitHub.
>>
>> Please have a look and suggest improvements.
>>
>> https://github.com/eldraco19/evalute_improve_checkpatch_pl
>>
>> Please let me know if there are any issues with this.
>
> So far, so good.
>
> Here are the questions we want to answer:
>
> - So what are the 20 categories that occur most?
>
> You are getting close to that answer, but you are not there yet.
>
> Then look at the findings. For those 20 categories, are there specific
> findings that are multiple times false positives?
>
> So, the script complains about something, but it does not get that the
> patch author wrote something completely unrelated to the error message.
>
> Lukas
Sir,
I tried the given tasks and it can be found here,
https://github.com/eldraco19/evalute_improve_checkpatch_pl/blob/master/STATS.md
Please look into it.
Thanks,
Ayush
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-08-24 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200810125354.xeijyh3v5upatrez@salamander>
2020-08-17 9:43 ` [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve checkpatch.pl" Lukas Bulwahn
2020-08-21 16:18 ` Ayush
2020-08-22 8:06 ` Lukas Bulwahn
2020-08-24 10:06 ` Ayush [this message]
2020-08-27 5:28 ` Lukas Bulwahn
2020-08-30 18:51 ` Ayush
2020-08-31 5:14 ` Lukas Bulwahn
2020-09-06 9:59 ` Ayush
2020-09-07 7:38 ` Lukas Bulwahn
2020-09-07 14:27 ` Ayush
2020-09-07 16:43 ` Lukas Bulwahn
2020-09-09 9:14 ` Ayush
2020-09-09 9:52 ` Lukas Bulwahn
2020-09-09 16:01 ` Ayush
2020-09-10 6:04 ` Lukas Bulwahn
2020-08-26 13:51 ` Ayush
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32595de077ee7d674a628df11c58152f@disroot.org \
--to=ayush@disroot.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).