From: "Michel Dänzer" <michel@daenzer.net>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <treding@nvidia.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.
Date: Mon, 7 Sep 2020 12:29:22 +0200 [thread overview]
Message-ID: <5ea9e575-e2ba-1f12-4894-3c0d271ea294@daenzer.net> (raw)
In-Reply-To: <20200907075559.GN2352366@phenom.ffwll.local>
On 2020-09-07 9:55 a.m., Daniel Vetter wrote:
> On Thu, Aug 06, 2020 at 12:52:54PM +0530, Vaibhav Gupta wrote:
>> Linux Kernel Mentee: Remove Legacy Power Management.
>>
>> The original goal of the patch series is to upgrade the power management
>> framework of radeonfb fbdev driver. This has been done by upgrading .suspend()
>> and .resume() callbacks.
>>
>> The upgrade makes sure that the involvement of PCI Core does not change the
>> order of operations executed in a driver. Thus, does not change its behavior.
>>
>> During this process, it was found that "#if defined(CONFIG_PM)" at line 1434 is
>> redundant. This was introduced in the commit
>> 42ddb453a0cd ("radeon: Conditionally compile PM code").
>
> I do wonder whether it wouldn't be better to just outright delete these,
> we have the drm radeon driver for pretty much all the same hardware ...
In contrast to radeonfb, the radeon driver doesn't support
suspend-to-RAM on Apple PowerPC notebooks.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-07 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 7:22 [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups Vaibhav Gupta
2020-08-06 7:26 ` Vaibhav Gupta
2020-08-06 7:26 ` [Linux-kernel-mentees] [PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container Vaibhav Gupta
2020-09-07 6:33 ` Vaibhav Gupta
2020-09-07 6:48 ` Greg KH
2020-09-07 6:52 ` Vaibhav Gupta
2020-08-06 7:26 ` [Linux-kernel-mentees] [PATCH v1 2/2] fbdev: radeonfb:use generic power management Vaibhav Gupta
2020-09-07 6:34 ` Vaibhav Gupta
2020-09-07 6:31 ` [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups Vaibhav Gupta
2020-09-07 6:47 ` Greg KH
2020-09-07 7:55 ` Daniel Vetter
2020-09-07 9:16 ` Vaibhav Gupta
2020-09-07 17:57 ` Daniel Vetter
2020-09-07 10:29 ` Michel Dänzer [this message]
2020-09-07 11:58 ` Benjamin Herrenschmidt
[not found] <CGME20200907070432eucas1p27ce44eec5f3eaf3644c868c7a965ee74@eucas1p2.samsung.com>
2020-09-07 7:02 ` Vaibhav Gupta
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea9e575-e2ba-1f12-4894-3c0d271ea294@daenzer.net \
--to=michel@daenzer.net \
--cc=b.zolnierkie@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=helgaas@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).