From: Aditya <yashsri421@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: add fix option for ERROR:GERRIT_CHANGE_ID
Date: Fri, 30 Oct 2020 16:24:50 +0530 [thread overview]
Message-ID: <84e3d147-097b-804b-405e-6f9a42157c81@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2010301147150.16621@felia>
On 30/10/20 4:19 pm, Lukas Bulwahn wrote:
>
>
> On Fri, 30 Oct 2020, Aditya wrote:
>
>> On 30/10/20 1:53 pm, Aditya Srivastava wrote:
>>> Currently, whenever gerrit change id is present in commit, checkpatch.pl
>>> gives an error to remove the change id before submitting the patch.
>>>
>>> For eg, running checkpatch on commit adc311a5bbf6 ("iwlwifi: bump FW
>>> API to 53 for 22000 series"), causes error:
>>>
>>> ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting
>>> upstream
>>> Change-Id: I5725e46394f3f53c3069723fd513cc53c7df383d
>>>
>>> But there is no --fix option present for this error message, in case
>>> user wants to fix it immediately.
>>>
>>> To fix this error, delete the corresponding line from the patchfile when
>>> checkpatch.pl is executed with --fix
>>>
>>> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
>>> ---
>>> scripts/checkpatch.pl | 7 +++++--
>>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>>> index 7800a090e8fe..5329927fc1c1 100755
>>> --- a/scripts/checkpatch.pl
>>> +++ b/scripts/checkpatch.pl
>>> @@ -2852,8 +2852,11 @@ sub process {
>>>
>>> # Check for Gerrit Change-Ids not in any patch context
>>> if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
>>> - ERROR("GERRIT_CHANGE_ID",
>>> - "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr);
>>> + if (ERROR("GERRIT_CHANGE_ID",
>>> + "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr) &&
>>> + $fix) {
>>> + fix_delete_line($fixlinenr, $rawline);
>>> + }
>>> }
>>>
>>> # Check if the commit log is in a possible stack dump
>>>
>>
>> Sir I have a doubt: Can I start working on another patch and send that
>> too before the first one gets accepted?
>>
>
> Sure, you can parallelize your work as much as you can.
> Review takes some time: we all have other full-time jobs and many other
> tasks.
>
> When you get feedback, though, I suggest to take that feedback immediately
> and consider reworking your patch.
>
> Lukas
>
Thanks Sir. Sure, will keep that in mind.
Aditya
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-30 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 8:23 [Linux-kernel-mentees] [PATCH] checkpatch: add fix option for ERROR:GERRIT_CHANGE_ID Aditya Srivastava
2020-10-30 9:37 ` Aditya
2020-10-30 10:49 ` Lukas Bulwahn
2020-10-30 10:54 ` Aditya [this message]
2020-10-30 10:45 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84e3d147-097b-804b-405e-6f9a42157c81@gmail.com \
--to=yashsri421@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).