Re: [PATCH v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative

From: Rajeshwar Shinde <coolrrsh@gmail.com>
To: broonie@kernel.org, linux-spi@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative
Date: Wed, 16 Aug 2023 11:38:48 +0530	[thread overview]
Message-ID: <CA+VNjV1=xVyRkvB6RAnLySAOzS=X1XiJihrtiMx3Jmifpdq9ng@mail.gmail.com> (raw)
In-Reply-To: <20230813141207.150336-1-coolrrsh@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1303 bytes --]

Please verify this patch.
Thanks & Regards

On Sun, 13 Aug, 2023, 7:42 pm , <coolrrsh@gmail.com> wrote:

> From: Rajeshwar R Shinde <coolrrsh@gmail.com>
>
> In struct mpc512x_psc_spi, the variable 'irq' is declared as an unsigned
> int.
> The comparison of variable 'irq'  with signed int operand is incorrect.
> Also,
> the return value from the call to platform_get_irq(pdev,0) is int and it
> is
> assigned to an unsigned int variable 'irq', thus redeclaring the type of
> variable 'irq' to signed int.
>
> This fixes warning such as:
> drivers/spi/spi-mpc512x-psc.c:493:5-13:
> WARNING: Unsigned expression compared with zero: mps -> irq < 0
>
> Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
>
> ---
> v1->v2
> changed the commit message
>
> ---
>  drivers/spi/spi-mpc512x-psc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c
> index 99aeef28a..5cecca1be 100644
> --- a/drivers/spi/spi-mpc512x-psc.c
> +++ b/drivers/spi/spi-mpc512x-psc.c
> @@ -53,7 +53,7 @@ struct mpc512x_psc_spi {
>         int type;
>         void __iomem *psc;
>         struct mpc512x_psc_fifo __iomem *fifo;
> -       unsigned int irq;
> +       int irq;
>         u8 bits_per_word;
>         u32 mclk_rate;
>
> --
> 2.25.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 1989 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees