From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Aditya <yashsri421@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: fix false positive for REPEATED_WORD warning
Date: Wed, 21 Oct 2020 18:29:04 +0530 [thread overview]
Message-ID: <CABJPP5CRkZKFaBjLLDmsaT=Tj19UwBUavB3sVRsRj23k0ncQ-A@mail.gmail.com> (raw)
In-Reply-To: <81e9cdec-d3c7-e5ba-0f2d-061fc0738385@gmail.com>
> # check for repeated words separated by a single space
> if ($rawline =~ /^\+/ || $in_commit_log) {
> - while ($rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
> + # avoid repeating hex occurrences like 'ff ff fe 09 ...'
Hey,
Probably one more change you could do here:
> + while ($rawline !~ /(\b[0-9a-f]{2}( )+){4,}/ &&
> + $rawline =~ /\b($word_pattern) (?=($word_pattern))/g) {
The hex check is performed everytime a duplicate word is found
in the line. A line with multiple duplicate words will lead to
unnecessary re run of the hex check.
Example:
"This is is the the repeated word"
Two repeated words: 'is' and 'the', and two runs
of the hex check on the same line.
Probably move it here?
+ if (($rawline =~ /^\+/ || $in_commit_log) &&
+ $rawline !~ /(\b[0-9a-f]{2}( )+){4,}/) {
Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-21 20:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 5:00 [Linux-kernel-mentees] [PATCH] checkpatch: fix false positive for REPEATED_WORD warning Aditya Srivastava
2020-10-21 5:15 ` Aditya
2020-10-21 6:12 ` Lukas Bulwahn
2020-10-21 8:20 ` Dwaipayan Ray
2020-10-21 8:35 ` Aditya
2020-10-21 8:52 ` Lukas Bulwahn
2020-10-21 12:09 ` Aditya
2020-10-21 12:53 ` Aditya
2020-10-21 12:58 ` Lukas Bulwahn
2020-10-21 12:59 ` Dwaipayan Ray [this message]
2020-10-21 14:44 Aditya Srivastava
2020-10-21 14:50 ` Lukas Bulwahn
2020-10-21 15:01 Aditya Srivastava
2020-10-21 15:08 ` Lukas Bulwahn
2020-10-21 15:18 ` Joe Perches
2020-10-21 15:28 ` Joe Perches
2020-10-21 16:50 ` Joe Perches
2020-10-21 16:59 ` Dwaipayan Ray
2020-10-21 17:17 ` Joe Perches
2020-10-21 17:55 ` Aditya
2020-10-21 18:05 ` Joe Perches
2020-10-21 18:25 ` Aditya
2020-10-21 19:12 ` Lukas Bulwahn
2020-10-22 14:21 ` Aditya
2020-10-22 14:35 ` Joe Perches
2020-10-21 19:10 ` Aditya
2020-10-21 19:26 ` Joe Perches
2020-10-21 20:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABJPP5CRkZKFaBjLLDmsaT=Tj19UwBUavB3sVRsRj23k0ncQ-A@mail.gmail.com' \
--to=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).