From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH v5] checkpatch: add new warnings to author signoff checks.
Date: Thu, 8 Oct 2020 00:23:45 +0530 [thread overview]
Message-ID: <CABJPP5CwuV8mKZzZqg3AjHubTqE3QzZC1zQyf+U+-Q=kRxKh9A@mail.gmail.com> (raw)
In-Reply-To: <b1f15283f770c71923920fef8fc6c643433d1ef9.camel@perches.com>
On Thu, Oct 8, 2020 at 12:14 AM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2020-10-08 at 00:08 +0530, Dwaipayan Ray wrote:
> > On Wed, Oct 7, 2020 at 11:48 PM Joe Perches <joe@perches.com> wrote:
> > > On Wed, 2020-10-07 at 12:08 +0530, Dwaipayan Ray wrote:
> > > > On Wed, Oct 7, 2020 at 12:03 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> > > > > The author signed-off-by checks are currently very vague.
> > > > > Cases like same name or same address are not handled separately.
> > >
> > > Likely now, the type should be changed from NO_AUTHOR_SIGN_OFF
> > > to a single something else for all the other types of messages.
> > >
> > >
> > Since BAD_SIGNOFF is being used for a different context, then
> > probably BAD_AUTHOR_SIGNOFF.
> >
> > Should this work or anything else you have in mind?
>
> That may be a bit too strong a wording as these aren't
> significant/bad defects.
>
> Maybe something like FROM_SIGNOFF_MISMATCH.
>
> It's not anything that would reject the patch.
>
> It's a pity type uses both SIGNOFF and SIGN_OFF.
>
Oh right sorry, It was a "visual mistake" on my part, it's SIGN_OFF
indeed and not SIGNOFF.
And I agree with the strong wording. So I will probably make it
FROM_SIGN_OFF_MISMATCH. And after that send in a
v6. (If I run out of single digit version numbers after this, it will
be embarrassing :( ).
Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2020-10-07 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 6:33 [Linux-kernel-mentees] [PATCH v5] checkpatch: add new warnings to author signoff checks Dwaipayan Ray
2020-10-07 6:38 ` Dwaipayan Ray
2020-10-07 18:18 ` Joe Perches
2020-10-07 18:38 ` Dwaipayan Ray
2020-10-07 18:44 ` Joe Perches
2020-10-07 18:53 ` Dwaipayan Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABJPP5CwuV8mKZzZqg3AjHubTqE3QzZC1zQyf+U+-Q=kRxKh9A@mail.gmail.com' \
--to=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).