From: Dipendra Khadka <kdipendra88@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, hpa@redhat.com,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h
Date: Sat, 23 Dec 2023 19:44:07 +0545 [thread overview]
Message-ID: <CAEKBCKPA0-VKA_r+YsGVb0cTKEQpV0dXwU8ARZ07LGmWuH2_OQ@mail.gmail.com> (raw)
In-Reply-To: <e7a46035-9c5e-495d-8f20-73dca4fec068@redhat.com>
Hi,
On Sat, 23 Dec 2023 at 16:10, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 12/23/23 06:18, Randy Dunlap wrote:
> > Hi Dipendra,
> >
> > On 12/22/23 21:11, Dipendra Khadka wrote:
> >> codespell reported spelling mistakes in
> >> ia_css_acc_types.h as below:
> >>
> >> '''
> >> ia_css_acc_types.h:87: cummulative ==> cumulative
> >> ia_css_acc_types.h:411: descibes ==> describes
> >> '''
> >>
> >> This patch fixes these spelling mistakes.
> >>
> >> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
> >
> > This patch is an improvement so it could be merged as is IMO.
> > But...
> >
> >> ---
> >> v2:
> >> - Previously only corrected spelling mistake reported by checkpatch.pl.
> >> - All spelling mistakes reported by codespell are fixed.
> >> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
> >>
> >> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> index d6e52b4971d6..1dc2085ecd61 100644
> >> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> @@ -84,7 +84,7 @@ struct ia_css_blob_info {
> >> memory_offsets; /** offset wrt hdr in bytes */
> >> u32 prog_name_offset; /** offset wrt hdr in bytes */
> >> u32 size; /** Size of blob */
> >> - u32 padding_size; /** total cummulative of bytes added due to section alignment */
> >> + u32 padding_size; /** total cumulative of bytes added due to section alignment */
> >
> > I apologize for not looking at your v1 patch carefully.
> > The comment above would be much better as
> >
> > /** total accumulation of bytes added due to section alignment */
>
> I agree that that is better. Dipendra can you please send a v3
> using the new text suggested by Randy ?
Sure,let me send a v3 with the new text suggested by Randy.
Regards,
Dipendra
>
> Regards,
>
> Hans
>
>
>
> >> u32 icache_source; /** Position of icache in blob */
> >> u32 icache_size; /** Size of icache section */
> >> u32 icache_padding;/** bytes added due to icache section alignment */
> >> @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
> >> };
> >>
> >> /* Acceleration firmware descriptor.
> >> - * This descriptor descibes either SP code (stand-alone), or
> >> + * This descriptor describes either SP code (stand-alone), or
> >> * ISP code (a separate pipeline stage).
> >> */
> >> struct ia_css_acc_fw_hdr {
> >
>
prev parent reply other threads:[~2023-12-23 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 5:11 [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h Dipendra Khadka
2023-12-23 5:18 ` Randy Dunlap
2023-12-23 5:29 ` Dipendra Khadka
2023-12-23 5:32 ` Randy Dunlap
2023-12-23 10:25 ` Hans de Goede
2023-12-23 13:59 ` Dipendra Khadka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEKBCKPA0-VKA_r+YsGVb0cTKEQpV0dXwU8ARZ07LGmWuH2_OQ@mail.gmail.com \
--to=kdipendra88@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).